Format control structures, classes, methods and function

To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

1 files changed, 16 insertions, 16 deletions

diff --git a/build/signed-off-checker.php b/build/signed-off-checker.php
index 43cf4529476..9620309932a 100644
--- a/build/signed-off-checker.php
+++ b/build/signed-off-checker.php
@@ -33,27 +33,27 @@ $repoName = getenv('DRONE_REPO_NAME');
 $droneEvent = getenv('DRONE_BUILD_EVENT');
 $githubToken = getenv('GITHUB_TOKEN');
 
-if(is_string($droneEvent) && $droneEvent === 'push') {
+if (is_string($droneEvent) && $droneEvent === 'push') {
 	echo("Push event - no signed-off check required.\n");
 	exit(0);
 }
 
-if(!is_string($pullRequestNumber) || $pullRequestNumber === '') {
+if (!is_string($pullRequestNumber) || $pullRequestNumber === '') {
 	echo("The environment variable DRONE_PULL_REQUEST has no proper value.\n");
 	exit(1);
 }
 
-if(!is_string($repoOwner) || $repoOwner === '') {
+if (!is_string($repoOwner) || $repoOwner === '') {
 	echo("The environment variable DRONE_REPO_OWNER has no proper value.\n");
 	exit(1);
 }
 
-if(!is_string($repoName) || $repoName === '') {
+if (!is_string($repoName) || $repoName === '') {
 	echo("The environment variable DRONE_REPO_NAME has no proper value.\n");
 	exit(1);
 }
 
-if(!is_string($githubToken) || $githubToken === '') {
+if (!is_string($githubToken) || $githubToken === '') {
 	echo("The environment variable GITHUB_TOKEN has no proper value.\n");
 	exit(1);
 }
@@ -67,7 +67,7 @@ $response = curl_exec($ch);
 curl_close($ch);
 
 $decodedResponse = json_decode($response, true);
-if(!is_array($decodedResponse) || count($decodedResponse) === 0) {
+if (!is_array($decodedResponse) || count($decodedResponse) === 0) {
 	echo("Could not decode JSON response from GitHub API.\n");
 	exit(1);
 }
@@ -75,47 +75,47 @@ if(!is_array($decodedResponse) || count($decodedResponse) === 0) {
 // Get all commits SHAs
 $commits = [];
 
-foreach($decodedResponse as $commit) {
-	if(!isset($commit['sha'])) {
+foreach ($decodedResponse as $commit) {
+	if (!isset($commit['sha'])) {
 		echo("No SHA specified in $commit\n");
 		exit(1);
 	}
-	if(!isset($commit['commit']['message'])) {
+	if (!isset($commit['commit']['message'])) {
 		echo("No commit message specified in $commit\n");
 		exit(1);
 	}
 	$commits[$commit['sha']] = $commit['commit']['message'];
 }
 
-if(count($commits) < 1) {
+if (count($commits) < 1) {
 	echo("Could not read commits.\n");
 	exit(1);
 }
 
 $notSignedCommits = [];
-foreach($commits as $commit => $message) {
-	if($commit === '') {
+foreach ($commits as $commit => $message) {
+	if ($commit === '') {
 		continue;
 	}
 
 	$signOffMessage = false;
 	$commitMessageLines = explode("\n", $message);
 
-	foreach($commitMessageLines as $line) {
-		if(preg_match('/^Signed-off-by: .* <.*@.*>$/', $line)) {
+	foreach ($commitMessageLines as $line) {
+		if (preg_match('/^Signed-off-by: .* <.*@.*>$/', $line)) {
 			echo "$commit is signed-off with \"$line\"\n";
 			$signOffMessage = true;
 			continue;
 		}
 	}
-	if($signOffMessage === true) {
+	if ($signOffMessage === true) {
 		continue;
 	}
 
 	$notSignedCommits[] = $commit;
 }
 
-if($notSignedCommits !== []) {
+if ($notSignedCommits !== []) {
 	echo("\n");
 	echo("Some commits were not signed off!\n");
 	echo("Missing signatures on:\n");