summaryrefslogtreecommitdiffstats
path: root/core/Controller
diff options
context:
space:
mode:
authorMorris Jobke <hey@morrisjobke.de>2016-07-07 12:14:45 +0200
committerMorris Jobke <hey@morrisjobke.de>2016-07-07 12:14:45 +0200
commit2791b8f00dec7136280e53175285de04f6c8f092 (patch)
tree9856834214b634a1177ded5b94f46d5a65d1e85d /core/Controller
parente3b509220b5e90646b54490fa081fa53880089e5 (diff)
downloadnextcloud-server-2791b8f00dec7136280e53175285de04f6c8f092.tar.gz
nextcloud-server-2791b8f00dec7136280e53175285de04f6c8f092.zip
Revert "occ web executor (#24957)"
This reverts commit 854352d9a064a1e469ede207493bce44fd41d96c.
Diffstat (limited to 'core/Controller')
-rw-r--r--core/Controller/OccController.php147
1 files changed, 0 insertions, 147 deletions
diff --git a/core/Controller/OccController.php b/core/Controller/OccController.php
deleted file mode 100644
index 917d02f37f1..00000000000
--- a/core/Controller/OccController.php
+++ /dev/null
@@ -1,147 +0,0 @@
-<?php
-/**
- * @author Victor Dubiniuk <dubiniuk@owncloud.com>
- *
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
- */
-
-namespace OC\Core\Controller;
-
-use OCP\AppFramework\Controller;
-use OCP\AppFramework\Http\JSONResponse;
-use OC\Console\Application;
-use OCP\IConfig;
-use OCP\IRequest;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Output\BufferedOutput;
-
-class OccController extends Controller {
-
- /** @var array */
- private $allowedCommands = [
- 'app:disable',
- 'app:enable',
- 'app:getpath',
- 'app:list',
- 'check',
- 'config:list',
- 'maintenance:mode',
- 'status',
- 'upgrade'
- ];
-
- /** @var IConfig */
- private $config;
- /** @var Application */
- private $console;
-
- /**
- * OccController constructor.
- *
- * @param string $appName
- * @param IRequest $request
- * @param IConfig $config
- * @param Application $console
- */
- public function __construct($appName, IRequest $request,
- IConfig $config, Application $console) {
- parent::__construct($appName, $request);
- $this->config = $config;
- $this->console = $console;
- }
-
- /**
- * @PublicPage
- * @NoCSRFRequired
- *
- * Execute occ command
- * Sample request
- * POST http://domain.tld/index.php/occ/status',
- * {
- * 'params': {
- * '--no-warnings':'1',
- * '--output':'json'
- * },
- * 'token': 'someToken'
- * }
- *
- * @param string $command
- * @param string $token
- * @param array $params
- *
- * @return JSONResponse
- * @throws \Exception
- */
- public function execute($command, $token, $params = []) {
- try {
- $this->validateRequest($command, $token);
-
- $output = new BufferedOutput();
- $formatter = $output->getFormatter();
- $formatter->setDecorated(false);
- $this->console->setAutoExit(false);
- $this->console->loadCommands(new ArrayInput([]), $output);
-
- $inputArray = array_merge(['command' => $command], $params);
- $input = new ArrayInput($inputArray);
-
- $exitCode = $this->console->run($input, $output);
- $response = $output->fetch();
-
- $json = [
- 'exitCode' => $exitCode,
- 'response' => $response
- ];
-
- } catch (\UnexpectedValueException $e){
- $json = [
- 'exitCode' => 126,
- 'response' => 'Not allowed',
- 'details' => $e->getMessage()
- ];
- }
- return new JSONResponse($json);
- }
-
- /**
- * Check if command is allowed and has a valid security token
- * @param $command
- * @param $token
- */
- protected function validateRequest($command, $token){
- if (!in_array($this->request->getRemoteAddress(), ['::1', '127.0.0.1', 'localhost'])) {
- throw new \UnexpectedValueException('Web executor is not allowed to run from a different host');
- }
-
- if (!in_array($command, $this->allowedCommands)) {
- throw new \UnexpectedValueException(sprintf('Command "%s" is not allowed to run via web request', $command));
- }
-
- $coreToken = $this->config->getSystemValue('updater.secret', '');
- if ($coreToken === '') {
- throw new \UnexpectedValueException(
- 'updater.secret is undefined in config/config.php. Either browse the admin settings in your ownCloud and click "Open updater" or define a strong secret using <pre>php -r \'echo password_hash("MyStrongSecretDoUseYourOwn!", PASSWORD_DEFAULT)."\n";\'</pre> and set this in the config.php.'
- );
- }
-
- if (!password_verify($token, $coreToken)) {
- throw new \UnexpectedValueException(
- 'updater.secret does not match the provided token'
- );
- }
- }
-}