summaryrefslogtreecommitdiffstats
path: root/core/Controller
diff options
context:
space:
mode:
authorPatrick Conrad <conrad@iza.org>2018-10-15 14:25:08 +0200
committerPatrick Conrad <conrad@iza.org>2018-10-15 14:46:06 +0200
commit1806baaeafa284808cceb1a38ea2e1a9189d0407 (patch)
tree031e964c963a8c8f335989df2cb01ae598ec7e09 /core/Controller
parent6f835aff31549a30d63e8bdcad4854f13120dbe5 (diff)
downloadnextcloud-server-1806baaeafa284808cceb1a38ea2e1a9189d0407.tar.gz
nextcloud-server-1806baaeafa284808cceb1a38ea2e1a9189d0407.zip
Remove cookies from Clear-Site-Data Header
In https://github.com/nextcloud/server/commit/2f87fb6b456fd109c90a5093c31b7a3f62a32040 this header was introduced. The referenced documentation says: > When delivered with a response from https://example.com/clear, the following header will cause cookies associated with the origin https://example.com to be cleared, as well as cookies on any origin in the same registered domain (e.g. https://www.example.com/ and https://more.subdomains.example.com/). This also applies if `https://nextcloud.example.com/` sends the `Clear-Site-Data: "cookies"` header. This is not the behavior we want at this point! So I removed the deletion of cookies from the header. This has no effect on the logout process as this header is supported only recently and the logout works in old browsers as well. Signed-off-by: Patrick Conrad <conrad@iza.org>
Diffstat (limited to 'core/Controller')
-rw-r--r--core/Controller/LoginController.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/Controller/LoginController.php b/core/Controller/LoginController.php
index ecb4e479206..a9fb22f21b7 100644
--- a/core/Controller/LoginController.php
+++ b/core/Controller/LoginController.php
@@ -131,7 +131,7 @@ class LoginController extends Controller {
$this->userSession->logout();
$response = new RedirectResponse($this->urlGenerator->linkToRouteAbsolute('core.login.showLoginForm'));
- $response->addHeader('Clear-Site-Data', '"cache", "cookies", "storage", "executionContexts"');
+ $response->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
return $response;
}