diff options
author | Joas Schilling <coding@schilljs.com> | 2021-12-13 09:28:13 +0100 |
---|---|---|
committer | Joas Schilling <coding@schilljs.com> | 2022-01-28 16:55:16 +0100 |
commit | fcb3e9a0712b3ffe0a0a6de6c3083515b4d531e9 (patch) | |
tree | 3697455b22f0fddd4fd9911027fe800483c9480a /core/Migrations/Version23000Date20210906132259.php | |
parent | e8c66d0f899a252ec56edcb2bfe31b8bfcc89a30 (diff) | |
download | nextcloud-server-fcb3e9a0712b3ffe0a0a6de6c3083515b4d531e9.tar.gz nextcloud-server-fcb3e9a0712b3ffe0a0a6de6c3083515b4d531e9.zip |
Add a primary key to ratelimit_entries table
Signed-off-by: Joas Schilling <coding@schilljs.com>
Diffstat (limited to 'core/Migrations/Version23000Date20210906132259.php')
-rw-r--r-- | core/Migrations/Version23000Date20210906132259.php | 43 |
1 files changed, 23 insertions, 20 deletions
diff --git a/core/Migrations/Version23000Date20210906132259.php b/core/Migrations/Version23000Date20210906132259.php index 26d18edc8f1..d4476a4d36d 100644 --- a/core/Migrations/Version23000Date20210906132259.php +++ b/core/Migrations/Version23000Date20210906132259.php @@ -11,8 +11,6 @@ use OCP\Migration\IOutput; use OCP\Migration\SimpleMigrationStep; class Version23000Date20210906132259 extends SimpleMigrationStep { - private const TABLE_NAME = 'ratelimit_entries'; - /** * @param IOutput $output * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper` @@ -20,24 +18,29 @@ class Version23000Date20210906132259 extends SimpleMigrationStep { * @return null|ISchemaWrapper */ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { - /** @var ISchemaWrapper $schema */ - $schema = $schemaClosure(); - - $hasTable = $schema->hasTable(self::TABLE_NAME); - - if (!$hasTable) { - $table = $schema->createTable(self::TABLE_NAME); - $table->addColumn('hash', Types::STRING, [ - 'notnull' => true, - 'length' => 128, - ]); - $table->addColumn('delete_after', Types::DATETIME, [ - 'notnull' => true, - ]); - $table->addIndex(['hash'], 'ratelimit_hash'); - $table->addIndex(['delete_after'], 'ratelimit_delete_after'); - return $schema; - } + /** + * Table was missing a primary key + * Therefore it was dropped with Version24000Date20211213081506 + * and then recreated with a primary key in Version24000Date20211213081604 + */ +// /** @var ISchemaWrapper $schema */ +// $schema = $schemaClosure(); +// +// $hasTable = $schema->hasTable(self::TABLE_NAME); +// +// if (!$hasTable) { +// $table = $schema->createTable(self::TABLE_NAME); +// $table->addColumn('hash', Types::STRING, [ +// 'notnull' => true, +// 'length' => 128, +// ]); +// $table->addColumn('delete_after', Types::DATETIME, [ +// 'notnull' => true, +// ]); +// $table->addIndex(['hash'], 'ratelimit_hash'); +// $table->addIndex(['delete_after'], 'ratelimit_delete_after'); +// return $schema; +// } return null; } |