diff options
| author | Côme Chilliet <come.chilliet@nextcloud.com> | 2023-10-12 17:04:11 +0200 |
|---|---|---|
| committer | Côme Chilliet <come.chilliet@nextcloud.com> | 2023-10-19 15:58:45 +0200 |
| commit | 0c346849f3904f4994ea306ef53884ffb87a2ee6 (patch) | |
| tree | 956af1767c85df52cb4dc2e89a9e4a345f7a5bbb /core/js | |
| parent | b6c35b3be0a2c2a26e6409990a3855c36fa06ce9 (diff) | |
| download | nextcloud-server-0c346849f3904f4994ea306ef53884ffb87a2ee6.tar.gz nextcloud-server-0c346849f3904f4994ea306ef53884ffb87a2ee6.zip | |
Migrate missing PHP modules check to new API and improve it
Test all modules listed as required in our documentation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Diffstat (limited to 'core/js')
| -rw-r--r-- | core/js/setupchecks.js | 10 | ||||
| -rw-r--r-- | core/js/tests/specs/setupchecksSpec.js | 25 |
2 files changed, 0 insertions, 35 deletions
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index a2bddefbe69..dd77c8603c4 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -383,16 +383,6 @@ type: OC.SetupChecks.MESSAGE_TYPE_INFO }) } - if (data.recommendedPHPModules.length > 0) { - var listOfRecommendedPHPModules = ""; - data.recommendedPHPModules.forEach(function(element){ - listOfRecommendedPHPModules += '<li>' + element + '</li>'; - }); - messages.push({ - msg: t('core', 'This instance is missing some recommended PHP modules. For improved performance and better compatibility it is highly recommended to install them.') + '<ul><code>' + listOfRecommendedPHPModules + '</code></ul>', - type: OC.SetupChecks.MESSAGE_TYPE_INFO - }) - } if (!data.isImagickEnabled) { messages.push({ msg: t( diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index 676111c80a4..dc257f9e69a 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -252,7 +252,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -323,7 +322,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -394,7 +392,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -462,7 +459,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -528,7 +524,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -594,7 +589,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -660,7 +654,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -726,7 +719,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -794,7 +786,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -860,7 +851,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -928,7 +918,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -994,7 +983,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1060,7 +1048,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1146,7 +1133,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1219,7 +1205,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1285,7 +1270,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1351,7 +1335,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: true, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1421,7 +1404,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1488,7 +1470,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1552,7 +1533,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: false, @@ -1619,7 +1599,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: false, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1686,7 +1665,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: false, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1752,7 +1730,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: false, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1818,7 +1795,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, @@ -1891,7 +1867,6 @@ describe('OC.SetupChecks tests', function() { isImagickEnabled: true, areWebauthnExtensionsEnabled: true, is64bit: true, - recommendedPHPModules: [], pendingBigIntConversionColumns: [], isMysqlUsedWithoutUTF8MB4: false, isEnoughTempSpaceAvailableIfS3PrimaryStorageIsUsed: true, |