diff options
| author | Côme Chilliet <come.chilliet@nextcloud.com> | 2023-11-14 16:07:37 +0100 |
|---|---|---|
| committer | Côme Chilliet <91878298+come-nc@users.noreply.github.com> | 2023-11-27 15:23:52 +0100 |
| commit | 1b547c7db88f872db999793f56554cb9e3a4366b (patch) | |
| tree | b362d7b59489764d19e79a35561fd434588e50b7 /core/js | |
| parent | ad88c04f2de08e2adda5dc2031699d892466fd94 (diff) | |
| download | nextcloud-server-1b547c7db88f872db999793f56554cb9e3a4366b.tar.gz nextcloud-server-1b547c7db88f872db999793f56554cb9e3a4366b.zip | |
Migrate missing primary key database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Diffstat (limited to 'core/js')
| -rw-r--r-- | core/js/setupchecks.js | 12 | ||||
| -rw-r--r-- | core/js/tests/specs/setupchecksSpec.js | 17 |
2 files changed, 0 insertions, 29 deletions
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index f926d1534a5..24fec85aeb3 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -258,18 +258,6 @@ type: OC.SetupChecks.MESSAGE_TYPE_WARNING }); } - if (data.missingPrimaryKeys.length > 0) { - var listOfMissingPrimaryKeys = ""; - data.missingPrimaryKeys.forEach(function(element){ - listOfMissingPrimaryKeys += '<li>'; - listOfMissingPrimaryKeys += t('core', 'Missing primary key on table "{tableName}".', element); - listOfMissingPrimaryKeys += '</li>'; - }); - messages.push({ - msg: t('core', 'The database is missing some primary keys. Due to the fact that adding primary keys on big tables could take some time they were not added automatically. By running "occ db:add-missing-primary-keys" those missing primary keys could be added manually while the instance keeps running.') + '<ul>' + listOfMissingPrimaryKeys + '</ul>', - type: OC.SetupChecks.MESSAGE_TYPE_INFO - }) - } if (!data.isImagickEnabled) { messages.push({ msg: t( diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index d48f92d5dc3..9020a895af5 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -229,7 +229,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -280,7 +279,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -331,7 +329,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -382,7 +379,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -431,7 +427,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -483,7 +478,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: false, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -533,7 +527,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -614,7 +607,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -670,7 +662,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: ['recommendation1', 'recommendation2'], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -719,7 +710,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -772,7 +762,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -822,7 +811,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -869,7 +857,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -919,7 +906,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -969,7 +955,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -1018,7 +1003,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -1074,7 +1058,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingPrimaryKeys: [], cronErrors: [], cronInfo: { diffInSeconds: 0 |