diff options
| author | Joas Schilling <213943+nickvergessen@users.noreply.github.com> | 2020-04-02 11:34:21 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-02 11:34:21 +0200 |
| commit | bc6a5ef5c4431ca662424dbd1125e65e74b27fa8 (patch) | |
| tree | a4ca41650699b5d9f9356eb4e7d5a5a10ab15ab2 /core/js | |
| parent | c1368b86963b93a42ec98a856f8d307d922c8967 (diff) | |
| parent | 1f5ba56235349ad811329b80cc1a2338dc8c79c7 (diff) | |
| download | nextcloud-server-bc6a5ef5c4431ca662424dbd1125e65e74b27fa8.tar.gz nextcloud-server-bc6a5ef5c4431ca662424dbd1125e65e74b27fa8.zip | |
Merge pull request #19890 from nextcloud/enh/comments-reference-id
Add optional comments reference_id
Diffstat (limited to 'core/js')
| -rw-r--r-- | core/js/setupchecks.js | 15 | ||||
| -rw-r--r-- | core/js/tests/specs/setupchecksSpec.js | 16 |
2 files changed, 31 insertions, 0 deletions
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index 12d1104a632..2e94c82486c 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -357,6 +357,21 @@ type: OC.SetupChecks.MESSAGE_TYPE_INFO }) } + if (data.missingColumns.length > 0) { + var listOfMissingColumns = ""; + data.missingColumns.forEach(function(element){ + listOfMissingColumns += "<li>"; + listOfMissingColumns += t('core', 'Missing optional column "{columnName}" in table "{tableName}".', element); + listOfMissingColumns += "</li>"; + }); + messages.push({ + msg: t( + 'core', + 'The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.' + ) + "<ul>" + listOfMissingColumns + "</ul>", + type: OC.SetupChecks.MESSAGE_TYPE_INFO + }) + } if (data.recommendedPHPModules.length > 0) { var listOfRecommendedPHPModules = ""; data.recommendedPHPModules.forEach(function(element){ diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index 5e93cbf7bdf..f4c81c6bf78 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -240,6 +240,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -293,6 +294,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -347,6 +349,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -399,6 +402,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -449,6 +453,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -499,6 +504,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -551,6 +557,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -601,6 +608,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: false, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -651,6 +659,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -722,6 +731,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -773,6 +783,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -824,6 +835,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -875,6 +887,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: false, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -925,6 +938,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -975,6 +989,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -1026,6 +1041,7 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, hasFreeTypeSupport: true, missingIndexes: [], + missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 |