diff options
| author | Côme Chilliet <come.chilliet@nextcloud.com> | 2023-11-14 15:14:14 +0100 |
|---|---|---|
| committer | backportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com> | 2023-12-04 16:23:23 +0000 |
| commit | d0a72a103d220fe15d34237e427f1ae0fec450c5 (patch) | |
| tree | 4b8850cd56509bbe78431d6014089cb3802fc7b4 /core | |
| parent | 9ab80200357e85b204ca29a3bac66ed4419357e5 (diff) | |
| download | nextcloud-server-d0a72a103d220fe15d34237e427f1ae0fec450c5.tar.gz nextcloud-server-d0a72a103d220fe15d34237e427f1ae0fec450c5.zip | |
Migrate missing column database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Diffstat (limited to 'core')
| -rw-r--r-- | core/js/setupchecks.js | 12 | ||||
| -rw-r--r-- | core/js/tests/specs/setupchecksSpec.js | 17 |
2 files changed, 0 insertions, 29 deletions
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index 1d64acf01ea..5cd2cadaa2d 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -282,18 +282,6 @@ type: OC.SetupChecks.MESSAGE_TYPE_INFO }) } - if (data.missingColumns.length > 0) { - var listOfMissingColumns = ""; - data.missingColumns.forEach(function(element){ - listOfMissingColumns += '<li>'; - listOfMissingColumns += t('core', 'Missing optional column "{columnName}" in table "{tableName}".', element); - listOfMissingColumns += '</li>'; - }); - messages.push({ - msg: t('core', 'The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.') + '<ul>' + listOfMissingColumns + '</ul>', - type: OC.SetupChecks.MESSAGE_TYPE_INFO - }) - } if (!data.isImagickEnabled) { messages.push({ msg: t( diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index d9124cfc84d..9cba013bb87 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -231,7 +231,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -284,7 +283,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -337,7 +335,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -390,7 +387,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -441,7 +437,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -495,7 +490,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: false, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -547,7 +541,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -630,7 +623,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -688,7 +680,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -739,7 +730,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -794,7 +784,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -846,7 +835,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -895,7 +883,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -947,7 +934,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -999,7 +985,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -1050,7 +1035,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 @@ -1108,7 +1092,6 @@ describe('OC.SetupChecks tests', function() { isSettimelimitAvailable: true, missingIndexes: [], missingPrimaryKeys: [], - missingColumns: [], cronErrors: [], cronInfo: { diffInSeconds: 0 |