summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorDaniel Calviño Sánchez <danxuliu@gmail.com>2017-09-29 01:36:10 +0200
committerDaniel Calviño Sánchez <danxuliu@gmail.com>2017-10-19 01:46:13 +0200
commitf392e78d5b525abbb04057b91c0adfba212c00c4 (patch)
treebd01ed1951dd3d6d9dd59ab3aa51040bc1dc6b9d /core
parent6b8713e8b6f45f79ec7cffd150c7f0136d7fb5b9 (diff)
downloadnextcloud-server-f392e78d5b525abbb04057b91c0adfba212c00c4.tar.gz
nextcloud-server-f392e78d5b525abbb04057b91c0adfba212c00c4.zip
Move checkboxes to their own column
The selection column is not only a visual column, but also a real column of the file list table. Unlike other columns whose width is reduced in space constrained screens the selection column must stay the same so the tapping area is large enough to be easily usable The selection column does not appear in the search results table, so its contents have to be explicitly aligned with those of the main table based on whether the main table has a selection column or not (using the "has-selection" CSS class in the same way as the "has-favorite" CSS class was being used when there was a column for favorite actions). In the tests the ":visible" selector can no longer be used. That selector matches elements with a width or height that is greater than zero, but the dimensions calculated in the unit tests are not reliable; the width of the link was zero before these changes, and now moving the checkbox to its own column causes the height of the link to become zero too, so it no longer matches the ":visible" selector even if it is not hidden. As hidding and showing the link is based on its "display" CSS property its value is the one checked now. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Diffstat (limited to 'core')
-rw-r--r--core/search/css/results.css9
1 files changed, 8 insertions, 1 deletions
diff --git a/core/search/css/results.css b/core/search/css/results.css
index 5369a3093d9..e2ccfe36ef8 100644
--- a/core/search/css/results.css
+++ b/core/search/css/results.css
@@ -30,6 +30,9 @@
padding: 28px 0 28px 56px;
font-size: 18px;
}
+.has-selection:not(.hidden) ~ #searchresults .status {
+ padding-left: 105px;
+}
#searchresults .status.fixed {
position: fixed;
bottom: 0;
@@ -51,7 +54,7 @@
}
#searchresults td {
- padding: 5px 19px;
+ padding: 5px 14px;
font-style: normal;
vertical-align: middle;
border-bottom: none;
@@ -64,6 +67,10 @@
background-position: right center;
background-repeat: no-repeat;
}
+.has-selection:not(.hidden) ~ #searchresults td.icon {
+ width: 91px;
+ background-size: 32px;
+}
#searchresults tr.template {
display: none;