aboutsummaryrefslogtreecommitdiffstats
path: root/cron.php
diff options
context:
space:
mode:
authorChristoph Wurst <christoph@winzerhof-wurst.at>2024-06-12 09:34:57 +0200
committerChristoph Wurst <christoph@winzerhof-wurst.at>2024-06-12 09:57:08 +0200
commit7ea6eac7434af728b0efe353e1ed235022e500e8 (patch)
tree0163d02c334a11ddff3a58e54da05fbeeb97c867 /cron.php
parent003e4b9939e693f16fa24ed4beb2e0d8b0d37168 (diff)
downloadnextcloud-server-7ea6eac7434af728b0efe353e1ed235022e500e8.tar.gz
nextcloud-server-7ea6eac7434af728b0efe353e1ed235022e500e8.zip
fix(cron): Log long running jobs
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Diffstat (limited to 'cron.php')
-rw-r--r--cron.php21
1 files changed, 20 insertions, 1 deletions
diff --git a/cron.php b/cron.php
index 8cd97258003..ca6d940bace 100644
--- a/cron.php
+++ b/cron.php
@@ -154,15 +154,34 @@ Options:
$jobDetails = get_class($job) . ' (id: ' . $job->getId() . ', arguments: ' . json_encode($job->getArgument()) . ')';
$logger->debug('CLI cron call has selected job ' . $jobDetails, ['app' => 'cron']);
+ $timeBefore = time();
$memoryBefore = memory_get_usage();
$memoryPeakBefore = memory_get_peak_usage();
/** @psalm-suppress DeprecatedMethod Calling execute until it is removed, then will switch to start */
$job->execute($jobList);
+ $timeAfter = time();
$memoryAfter = memory_get_usage();
$memoryPeakAfter = memory_get_peak_usage();
+ $cronInterval = 5 * 60;
+ $timeSpent = $timeAfter - $timeBefore;
+ if ($timeSpent > $cronInterval) {
+ $logLevel = match (true) {
+ $timeSpent > $cronInterval * 128 => \OCP\ILogger::FATAL,
+ $timeSpent > $cronInterval * 64 => \OCP\ILogger::ERROR,
+ $timeSpent > $cronInterval * 16 => \OCP\ILogger::WARN,
+ $timeSpent > $cronInterval * 8 => \OCP\ILogger::INFO,
+ default => \OCP\ILogger::DEBUG,
+ };
+ $logger->log(
+ $logLevel,
+ 'Background job ' . $jobDetails . ' ran for ' . $timeSpent . ' seconds',
+ ['app' => 'cron']
+ );
+ }
+
if ($memoryAfter - $memoryBefore > 10_000_000) {
$logger->warning('Used memory grew by more than 10 MB when executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryAfter). ' (before: ' . Util::humanFileSize($memoryBefore) . ')', ['app' => 'cron']);
}
@@ -178,7 +197,7 @@ Options:
$executedJobs[$job->getId()] = true;
unset($job);
- if (time() > $endTime) {
+ if ($timeAfter > $endTime) {
break;
}
}