fix(files): Provide file actions from list entry to make it reactive

This fixes non reactive default action text of the name component.
Also use download action as default action so that only one place
is needed to define how to download a file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

3 files changed, 151 insertions, 4 deletions

diff --git a/cypress/e2e/files/files-download.cy.ts b/cypress/e2e/files/files-download.cy.ts
new file mode 100644
index 00000000000..5522fb947d6
--- /dev/null
+++ b/cypress/e2e/files/files-download.cy.ts
@@ -0,0 +1,145 @@
+/*!
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import type { User } from '@nextcloud/cypress'
+import { getRowForFile, navigateToFolder, triggerActionForFile } from './FilesUtils'
+import { deleteDownloadsFolderBeforeEach } from 'cypress-delete-downloads-folder'
+
+describe('files: Download files using file actions', { testIsolation: true }, () => {
+	let user: User
+
+	deleteDownloadsFolderBeforeEach()
+
+	beforeEach(() => {
+		cy.createRandomUser().then(($user) => {
+			user = $user
+		})
+	})
+
+	it('can download file', () => {
+		cy.uploadContent(user, new Blob(['<content>']), 'text/plain', '/file.txt')
+		cy.login(user)
+		cy.visit('/apps/files')
+
+		getRowForFile('file.txt').should('be.visible')
+
+		triggerActionForFile('file.txt', 'download')
+
+		const downloadsFolder = Cypress.config('downloadsFolder')
+		cy.readFile(`${downloadsFolder}/file.txt`, { timeout: 15000 })
+			.should('exist')
+			.and('have.length.gt', 8)
+			.and('equal', '<content>')
+	})
+
+	/**
+	 * Regression test of https://github.com/nextcloud/server/issues/44855
+	 */
+	it('can download file with hash name', () => {
+		cy.uploadContent(user, new Blob(['<content>']), 'text/plain', '/#file.txt')
+		cy.login(user)
+		cy.visit('/apps/files')
+
+		triggerActionForFile('#file.txt', 'download')
+		const downloadsFolder = Cypress.config('downloadsFolder')
+		cy.readFile(`${downloadsFolder}/#file.txt`, { timeout: 15000 })
+			.should('exist')
+			.and('have.length.gt', 8)
+			.and('equal', '<content>')
+	})
+
+	/**
+	 * Regression test of https://github.com/nextcloud/server/issues/44855
+	 */
+	it('can download file from folder with hash name', () => {
+		cy.mkdir(user, '/#folder')
+			.uploadContent(user, new Blob(['<content>']), 'text/plain', '/#folder/file.txt')
+		cy.login(user)
+		cy.visit('/apps/files')
+
+		navigateToFolder('#folder')
+		// All are visible by default
+		getRowForFile('file.txt').should('be.visible')
+
+		triggerActionForFile('file.txt', 'download')
+		const downloadsFolder = Cypress.config('downloadsFolder')
+		cy.readFile(`${downloadsFolder}/file.txt`, { timeout: 15000 })
+			.should('exist')
+			.and('have.length.gt', 8)
+			.and('equal', '<content>')
+	})
+})
+
+describe('files: Download files using default action', { testIsolation: true }, () => {
+	let user: User
+
+	deleteDownloadsFolderBeforeEach()
+
+	beforeEach(() => {
+		cy.createRandomUser().then(($user) => {
+			user = $user
+		})
+	})
+
+	it('can download file', () => {
+		cy.uploadContent(user, new Blob(['<content>']), 'text/plain', '/file.txt')
+		cy.login(user)
+		cy.visit('/apps/files')
+
+		getRowForFile('file.txt')
+			.should('be.visible')
+			.findByRole('button', { name: 'Download' })
+			.click()
+
+		const downloadsFolder = Cypress.config('downloadsFolder')
+		cy.readFile(`${downloadsFolder}/file.txt`, { timeout: 15000 })
+			.should('exist')
+			.and('have.length.gt', 8)
+			.and('equal', '<content>')
+	})
+
+	/**
+	 * Regression test of https://github.com/nextcloud/server/issues/44855
+	 */
+	it('can download file with hash name', () => {
+		cy.uploadContent(user, new Blob(['<content>']), 'text/plain', '/#file.txt')
+		cy.login(user)
+		cy.visit('/apps/files')
+
+		getRowForFile('#file.txt')
+			.should('be.visible')
+			.findByRole('button', { name: 'Download' })
+			.click()
+
+		const downloadsFolder = Cypress.config('downloadsFolder')
+		cy.readFile(`${downloadsFolder}/#file.txt`, { timeout: 15000 })
+			.should('exist')
+			.and('have.length.gt', 8)
+			.and('equal', '<content>')
+	})
+
+	/**
+	 * Regression test of https://github.com/nextcloud/server/issues/44855
+	 */
+	it('can download file from folder with hash name', () => {
+		cy.mkdir(user, '/#folder')
+			.uploadContent(user, new Blob(['<content>']), 'text/plain', '/#folder/file.txt')
+		cy.login(user)
+		cy.visit('/apps/files')
+
+		navigateToFolder('#folder')
+		// All are visible by default
+		getRowForFile('file.txt')
+			.should('be.visible')
+			.findByRole('button', { name: 'Download' })
+			.click()
+
+		const downloadsFolder = Cypress.config('downloadsFolder')
+		cy.readFile(`${downloadsFolder}/file.txt`, { timeout: 15000 })
+			.should('exist')
+			.and('have.length.gt', 8)
+			.and('equal', '<content>')
+	})
+})
diff --git a/cypress/e2e/files_sharing/file-request.cy.ts b/cypress/e2e/files_sharing/file-request.cy.ts
index 793383e9a77..7c33594e25c 100644
--- a/cypress/e2e/files_sharing/file-request.cy.ts
+++ b/cypress/e2e/files_sharing/file-request.cy.ts
@@ -4,7 +4,7 @@
  */
 
 import type { User } from '@nextcloud/cypress'
-import { createFolder, getRowForFile } from '../files/FilesUtils'
+import { createFolder, getRowForFile, navigateToFolder } from '../files/FilesUtils'
 import { createFileRequest, enterGuestName } from './FilesSharingUtils'
 
 describe('Files', { testIsolation: true }, () => {
@@ -53,7 +53,9 @@ describe('Files', { testIsolation: true }, () => {
 	it('Check the uploaded file', () => {
 		cy.login(user)
 		cy.visit(`/apps/files/files?dir=/${folderName}`)
-		getRowForFile('Guest').should('be.visible').get('a[data-cy-files-list-row-name-link]').click()
+		getRowForFile('Guest')
+			.should('be.visible')
+		navigateToFolder('Guest')
 		getRowForFile('file.txt').should('be.visible')
 	})
 })
diff --git a/cypress/e2e/files_sharing/files-shares-view.cy.ts b/cypress/e2e/files_sharing/files-shares-view.cy.ts
index 01083e6dda9..12a67d9ee0f 100644
--- a/cypress/e2e/files_sharing/files-shares-view.cy.ts
+++ b/cypress/e2e/files_sharing/files-shares-view.cy.ts
@@ -35,7 +35,7 @@ describe('files_sharing: Files view', { testIsolation: true }, () => {
 		// see the shared folder
 		getRowForFile('folder').should('be.visible')
 		// click on the folder should open it in files
-		getRowForFile('folder').findByRole('button', { name: 'folder' }).click()
+		getRowForFile('folder').findByRole('button', { name: /open in files/i }).click()
 		// See the URL has changed
 		cy.url().should('match', /apps\/files\/files\/.+dir=\/folder/)
 		// Content of the shared folder
@@ -50,7 +50,7 @@ describe('files_sharing: Files view', { testIsolation: true }, () => {
 		// see the shared folder
 		getRowForFile('folder').should('be.visible')
 		// click on the folder should open it in files
-		getRowForFile('folder').findByRole('button', { name: 'folder' }).click()
+		getRowForFile('folder').findByRole('button', { name: /open in files/i }).click()
 		// See the URL has changed
 		cy.url().should('match', /apps\/files\/files\/.+dir=\/folder/)
 		// Content of the shared folder