summaryrefslogtreecommitdiffstats
path: root/lib/private/AppFramework/Http/Request.php
diff options
context:
space:
mode:
authorLukas Reschke <lukas@statuscode.ch>2016-07-20 17:37:30 +0200
committerLukas Reschke <lukas@statuscode.ch>2016-07-20 18:37:57 +0200
commita299fa38a9172f16e4bc48d4bd4f9807cec2f737 (patch)
treeabd17d7cc5eabc8acf7cb5b1acb30a12abe1581e /lib/private/AppFramework/Http/Request.php
parent7cdf6402ff9a0e07866ca8bcfcffd0e0897b646a (diff)
downloadnextcloud-server-a299fa38a9172f16e4bc48d4bd4f9807cec2f737.tar.gz
nextcloud-server-a299fa38a9172f16e4bc48d4bd4f9807cec2f737.zip
[master] Port Same-Site Cookies to master
Fixes https://github.com/nextcloud/server/issues/50
Diffstat (limited to 'lib/private/AppFramework/Http/Request.php')
-rw-r--r--lib/private/AppFramework/Http/Request.php40
1 files changed, 40 insertions, 0 deletions
diff --git a/lib/private/AppFramework/Http/Request.php b/lib/private/AppFramework/Http/Request.php
index d9cf1919252..8fc99f125b2 100644
--- a/lib/private/AppFramework/Http/Request.php
+++ b/lib/private/AppFramework/Http/Request.php
@@ -465,6 +465,10 @@ class Request implements \ArrayAccess, \Countable, IRequest {
return false;
}
+ if(!$this->passesStrictCookieCheck()) {
+ return false;
+ }
+
if (isset($this->items['get']['requesttoken'])) {
$token = $this->items['get']['requesttoken'];
} elseif (isset($this->items['post']['requesttoken'])) {
@@ -481,6 +485,42 @@ class Request implements \ArrayAccess, \Countable, IRequest {
}
/**
+ * Checks if the strict cookie has been sent with the request if the request
+ * is including any cookies.
+ *
+ * @return bool
+ * @since 9.1.0
+ */
+ public function passesStrictCookieCheck() {
+ if(count($this->cookies) === 0) {
+ return true;
+ }
+ if($this->getCookie('nc_sameSiteCookiestrict') === 'true'
+ && $this->passesLaxCookieCheck()) {
+ return true;
+ }
+ return false;
+ }
+
+ /**
+ * Checks if the lax cookie has been sent with the request if the request
+ * is including any cookies.
+ *
+ * @return bool
+ * @since 9.1.0
+ */
+ public function passesLaxCookieCheck() {
+ if(count($this->cookies) === 0) {
+ return true;
+ }
+ if($this->getCookie('nc_sameSiteCookielax') === 'true') {
+ return true;
+ }
+ return false;
+ }
+
+
+ /**
* Returns an ID for the request, value is not guaranteed to be unique and is mostly meant for logging
* If `mod_unique_id` is installed this value will be taken.
* @return string