summaryrefslogtreecommitdiffstats
path: root/lib/private/Collaboration
diff options
context:
space:
mode:
authorJoas Schilling <coding@schilljs.com>2020-09-23 10:21:55 +0200
committerJoas Schilling <coding@schilljs.com>2020-09-23 10:21:55 +0200
commit5415eeda43e5c459eb99272b28b291efb78c1d74 (patch)
tree46c1573d31fc4f2ab586f8bbc6be2fa5e69cbfac /lib/private/Collaboration
parent7d0602792280f88af6867db0131d1bf8984b2c2c (diff)
downloadnextcloud-server-5415eeda43e5c459eb99272b28b291efb78c1d74.tar.gz
nextcloud-server-5415eeda43e5c459eb99272b28b291efb78c1d74.zip
Show federation and email results also with exact user match unless containing @
Before when you have a user "smith" and a federated user "smith@example.com" you could see the federation result with "smit" but not with "smith" anymore. With most LDAP configurations and local backend setups this is disturbing and causes issues. The idea of not showing the email and federation on a matching user was with: Local user registered with "smith@example.com" user id and having that same email / cloud id in your contacts addressbook. So we now only hide those "side results" when the search does contain an @ Signed-off-by: Joas Schilling <coding@schilljs.com>
Diffstat (limited to 'lib/private/Collaboration')
-rw-r--r--lib/private/Collaboration/Collaborators/Search.php5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/private/Collaboration/Collaborators/Search.php b/lib/private/Collaboration/Collaborators/Search.php
index 1aabd423371..e7773858e5c 100644
--- a/lib/private/Collaboration/Collaborators/Search.php
+++ b/lib/private/Collaboration/Collaborators/Search.php
@@ -91,9 +91,10 @@ class Search implements ISearch {
$searchResult->unsetResult($emailType);
}
- // if we have an exact local user match, there is no need to show the remote and email matches
+ // if we have an exact local user match with an email-a-like query,
+ // there is no need to show the remote and email matches.
$userType = new SearchResultType('users');
- if ($searchResult->hasExactIdMatch($userType)) {
+ if (strpos($search, '@') !== false && $searchResult->hasExactIdMatch($userType)) {
$searchResult->unsetResult($remoteType);
$searchResult->unsetResult($emailType);
}