diff options
| author | Josh <josh.t.richards@gmail.com> | 2024-06-03 17:31:26 -0400 |
|---|---|---|
| committer | Josh Richards <josh.t.richards@gmail.com> | 2024-06-12 15:43:20 -0400 |
| commit | 63886147bac7bc5fded32dba02ddc72db416babf (patch) | |
| tree | 3891bdf69acf5577c81e1d33d666eabb50f0e270 /lib/private/Files/ObjectStore | |
| parent | 6ec6c1fe4fbebd5c811c45600d79e1835da4b1c2 (diff) | |
| download | nextcloud-server-63886147bac7bc5fded32dba02ddc72db416babf.tar.gz nextcloud-server-63886147bac7bc5fded32dba02ddc72db416babf.zip | |
fix(ObjectStore): handle empty S3 hostname
Fixes #45637
The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).
Signed-off-by: Josh <josh.t.richards@gmail.com>
Diffstat (limited to 'lib/private/Files/ObjectStore')
| -rw-r--r-- | lib/private/Files/ObjectStore/S3ConnectionTrait.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/private/Files/ObjectStore/S3ConnectionTrait.php b/lib/private/Files/ObjectStore/S3ConnectionTrait.php index 02f5e5ded04..c7a5a8a1add 100644 --- a/lib/private/Files/ObjectStore/S3ConnectionTrait.php +++ b/lib/private/Files/ObjectStore/S3ConnectionTrait.php @@ -44,8 +44,8 @@ trait S3ConnectionTrait { $this->copySizeLimit = $params['copySizeLimit'] ?? 5242880000; $this->useMultipartCopy = (bool)($params['useMultipartCopy'] ?? true); $params['region'] = empty($params['region']) ? 'eu-west-1' : $params['region']; - $params['s3-accelerate'] = $params['hostname'] == 's3-accelerate.amazonaws.com' || $params['hostname'] == 's3-accelerate.dualstack.amazonaws.com'; $params['hostname'] = empty($params['hostname']) ? 's3.' . $params['region'] . '.amazonaws.com' : $params['hostname']; + $params['s3-accelerate'] = $params['hostname'] === 's3-accelerate.amazonaws.com' || $params['hostname'] === 's3-accelerate.dualstack.amazonaws.com'; if (!isset($params['port']) || $params['port'] === '') { $params['port'] = (isset($params['use_ssl']) && $params['use_ssl'] === false) ? 80 : 443; } |