summaryrefslogtreecommitdiffstats
path: root/lib/private/Session
diff options
context:
space:
mode:
authorVictor Dubiniuk <victor.dubiniuk@gmail.com>2017-04-12 21:25:22 +0300
committerJoas Schilling <coding@schilljs.com>2017-04-25 16:28:52 +0200
commit131df248ef29f2dd1d78a1dd43b1fe09a65b3a48 (patch)
tree79d2b8f766f597add4ac3d07e289bdcf99a4ff3a /lib/private/Session
parent8ef25a7628d44465d4777686227407f9a2067700 (diff)
downloadnextcloud-server-131df248ef29f2dd1d78a1dd43b1fe09a65b3a48.tar.gz
nextcloud-server-131df248ef29f2dd1d78a1dd43b1fe09a65b3a48.zip
Catch session already closed exception in destructor
Diffstat (limited to 'lib/private/Session')
-rw-r--r--lib/private/Session/CryptoSessionData.php7
-rw-r--r--lib/private/Session/Internal.php2
2 files changed, 7 insertions, 2 deletions
diff --git a/lib/private/Session/CryptoSessionData.php b/lib/private/Session/CryptoSessionData.php
index 4e0b852cb35..31fcea4a7a6 100644
--- a/lib/private/Session/CryptoSessionData.php
+++ b/lib/private/Session/CryptoSessionData.php
@@ -64,7 +64,12 @@ class CryptoSessionData implements \ArrayAccess, ISession {
* Close session if class gets destructed
*/
public function __destruct() {
- $this->close();
+ try {
+ $this->close();
+ } catch (SessionNotAvailableException $e){
+ // This exception can occur if session is already closed
+ // So it is safe to ignore it and let the garbage collector to proceed
+ }
}
protected function initializeSession() {
diff --git a/lib/private/Session/Internal.php b/lib/private/Session/Internal.php
index 22878154c05..72af5727a54 100644
--- a/lib/private/Session/Internal.php
+++ b/lib/private/Session/Internal.php
@@ -151,7 +151,7 @@ class Internal extends Session {
*/
private function validateSession() {
if ($this->sessionClosed) {
- throw new \Exception('Session has been closed - no further changes to the session are allowed');
+ throw new SessionNotAvailableException('Session has been closed - no further changes to the session are allowed');
}
}
}