diff options
author | Arthur Schiwon <blizzz@owncloud.com> | 2014-04-15 17:46:48 +0200 |
---|---|---|
committer | Arthur Schiwon <blizzz@owncloud.com> | 2014-04-15 17:46:48 +0200 |
commit | 64679b2e62909df9b3e493a0dc22151b5baae1a6 (patch) | |
tree | e55be82c0549b40d1a42938bc0e42446c1d27ace /lib/private/group/group.php | |
parent | d826f33fae85e8ad68bd5d7b2b3a10cdeddf8827 (diff) | |
download | nextcloud-server-64679b2e62909df9b3e493a0dc22151b5baae1a6.tar.gz nextcloud-server-64679b2e62909df9b3e493a0dc22151b5baae1a6.zip |
Remove limit and offset manipulation when getting users or groups, because it does not work when more than one user or group backend. Fixing it would be too costly performancewise, so we switch back to the model used in OC 5: limit and offset are effective per backend, and not a general constraint
Diffstat (limited to 'lib/private/group/group.php')
-rw-r--r-- | lib/private/group/group.php | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/lib/private/group/group.php b/lib/private/group/group.php index a2b8a0dcbea..3efbb6e7023 100644 --- a/lib/private/group/group.php +++ b/lib/private/group/group.php @@ -172,12 +172,6 @@ class Group { $users = array(); foreach ($this->backends as $backend) { $userIds = $backend->usersInGroup($this->gid, $search, $limit, $offset); - if (!is_null($limit)) { - $limit -= count($userIds); - } - if (!is_null($offset)) { - $offset -= count($userIds); - } $users += $this->getVerifiedUsers($userIds); if (!is_null($limit) and $limit <= 0) { return array_values($users); @@ -223,12 +217,6 @@ class Group { } else { $userIds = $backend->usersInGroup($this->gid, $search, $limit, $offset); } - if (!is_null($limit)) { - $limit -= count($userIds); - } - if (!is_null($offset)) { - $offset -= count($userIds); - } $users = $this->getVerifiedUsers($userIds); if (!is_null($limit) and $limit <= 0) { return array_values($users); |