diff options
author | Lukas Reschke <lukas@statuscode.ch> | 2016-10-07 21:53:01 +0200 |
---|---|---|
committer | Lukas Reschke <lukas@statuscode.ch> | 2016-10-07 21:56:43 +0200 |
commit | 0245dd7221b6901aab0118688a1a16328248d530 (patch) | |
tree | 41a21191068cda8f2836bead68ea20f313ef3e3f /lib/private/legacy | |
parent | bccc4e618a58281f390b6baa88cc0b03b1e40172 (diff) | |
download | nextcloud-server-0245dd7221b6901aab0118688a1a16328248d530.tar.gz nextcloud-server-0245dd7221b6901aab0118688a1a16328248d530.zip |
Simplify isSubDirectory check
Shaves off another 9ms per request as can be seen at https://blackfire.io/profiles/compare/dd54cef3-e58d-4a22-b8f4-c7c4b70697be/graph
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Diffstat (limited to 'lib/private/legacy')
-rw-r--r-- | lib/private/legacy/helper.php | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/lib/private/legacy/helper.php b/lib/private/legacy/helper.php index b19e58a9e6c..0b9477dacd4 100644 --- a/lib/private/legacy/helper.php +++ b/lib/private/legacy/helper.php @@ -378,32 +378,6 @@ class OC_Helper { } /** - * Checks if $sub is a subdirectory of $parent - * - * @param string $sub - * @param string $parent - * @return bool - */ - public static function isSubDirectory($sub, $parent) { - $realpathSub = realpath($sub); - $realpathParent = realpath($parent); - - // realpath() may return false in case the directory does not exist - // since we can not be sure how different PHP versions may behave here - // we do an additional check whether realpath returned false - if($realpathSub === false || $realpathParent === false) { - return false; - } - - // Check whether $sub is a subdirectory of $parent - if (strpos($realpathSub, $realpathParent) === 0) { - return true; - } - - return false; - } - - /** * Returns an array with all keys from input lowercased or uppercased. Numbered indices are left as is. * * @param array $input The array to work on |