diff options
| author | Josh Richards <josh.t.richards@gmail.com> | 2023-06-03 08:57:38 -0400 |
|---|---|---|
| committer | yemkareems <yemkareems@gmail.com> | 2024-11-13 09:11:17 +0530 |
| commit | 1fc1543a8bcffa04f0c4d42ba2252409c8876041 (patch) | |
| tree | 100e3e14795208077fc7e23245086e3b18cc2938 /lib/private | |
| parent | 0da87f178f1db975a1c3f9212b99ac01f4bae874 (diff) | |
| download | nextcloud-server-1fc1543a8bcffa04f0c4d42ba2252409c8876041.tar.gz nextcloud-server-1fc1543a8bcffa04f0c4d42ba2252409c8876041.zip | |
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Diffstat (limited to 'lib/private')
| -rw-r--r-- | lib/private/Files/Storage/Common.php | 2 | ||||
| -rw-r--r-- | lib/private/Files/Storage/PolyFill/CopyDirectory.php | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/private/Files/Storage/Common.php b/lib/private/Files/Storage/Common.php index 5ffac31d682..d4f3d1ddc84 100644 --- a/lib/private/Files/Storage/Common.php +++ b/lib/private/Files/Storage/Common.php @@ -192,7 +192,7 @@ abstract class Common implements Storage, ILockingStorage, IWriteStreamStorage { $this->remove($target); $dir = $this->opendir($source); $this->mkdir($target); - while ($file = readdir($dir)) { + while (($file = readdir($dir)) !== false) { if (!Filesystem::isIgnoredDir($file)) { if (!$this->copy($source . '/' . $file, $target . '/' . $file)) { closedir($dir); diff --git a/lib/private/Files/Storage/PolyFill/CopyDirectory.php b/lib/private/Files/Storage/PolyFill/CopyDirectory.php index 4b3e367da78..5fe396d97e1 100644 --- a/lib/private/Files/Storage/PolyFill/CopyDirectory.php +++ b/lib/private/Files/Storage/PolyFill/CopyDirectory.php @@ -70,7 +70,7 @@ trait CopyDirectory { protected function copyRecursive($source, $target) { $dh = $this->opendir($source); $result = true; - while ($file = readdir($dh)) { + while (($file = readdir($dh)) !== false) { if (!\OC\Files\Filesystem::isIgnoredDir($file)) { if ($this->is_dir($source . '/' . $file)) { $this->mkdir($target . '/' . $file); |