diff options
author | Ferdinand Thiessen <opensource@fthiessen.de> | 2025-03-18 14:25:26 +0100 |
---|---|---|
committer | Ferdinand Thiessen <opensource@fthiessen.de> | 2025-03-18 15:34:28 +0100 |
commit | d5efd17942cc901b82ccc4717b6bf755dc565997 (patch) | |
tree | 81e0621f38e5873e55230c56ca3c7a90a7b79f24 /lib/private | |
parent | 9d738f6124fbe66b8e10a05ef596022617b526ac (diff) | |
download | nextcloud-server-d5efd17942cc901b82ccc4717b6bf755dc565997.tar.gz nextcloud-server-d5efd17942cc901b82ccc4717b6bf755dc565997.zip |
fix(IMimeTypeDetector): use correct return typefix/IMimeTypeDetector-types
In PHP array keys that are integers are always kept as integer,
meaning the type of the key of `$a = ["1" => "one"]` will be integer not
string.
While are hacks to circumvent this (case std object with string keys to
an assoc. array) those hacks are performance wise awefull and also not
needed as in PHP you can always access that element with `$a[1]` or
`$a["1"]`.
So TL;DR;: do not lie about return types.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Diffstat (limited to 'lib/private')
-rw-r--r-- | lib/private/Files/Type/Detection.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/private/Files/Type/Detection.php b/lib/private/Files/Type/Detection.php index 48907b3473f..09d73231f22 100644 --- a/lib/private/Files/Type/Detection.php +++ b/lib/private/Files/Type/Detection.php @@ -23,7 +23,7 @@ class Detection implements IMimeTypeDetector { private const CUSTOM_MIMETYPEMAPPING = 'mimetypemapping.json'; private const CUSTOM_MIMETYPEALIASES = 'mimetypealiases.json'; - /** @var array<string, list{string, string|null}> */ + /** @var array<list{string, string|null}> */ protected array $mimetypes = []; protected array $secureMimeTypes = []; @@ -140,7 +140,7 @@ class Detection implements IMimeTypeDetector { } /** - * @return array<string, list{string, string|null}> + * @return array<list{string, string|null}> */ public function getAllMappings(): array { $this->loadMappings(); |