Fix totally broken AppStore

As it turned out the AppStore code was completely broken when it came from apps delivered from the appstore, this meant:

1. You could not disable and then re-enable an application that was installed from the AppStore. It simply failed hard.
2. You could not disable apps from the categories but only from the "Activated" page
3. It did not show the activation state from any category page

This code is completely static and thus testing it is impossible. We really have to stop with "let's add yet another feature in already existing static code". Such stuff has to get refactored first.

That said, this code works from what I can say when clicking around in the AppStore page GUI. However, it may easily be that it does not work with updates or whatsever as I have no chance to test that since the AppStore code is not open-source and it is impossible to write unit-tests for that.

Fixes https://github.com/owncloud/core/issues/14711

1 files changed, 9 insertions, 0 deletions

diff --git a/lib/public/iconfig.php b/lib/public/iconfig.php
index 868a4133d2e..06638d0891b 100644
--- a/lib/public/iconfig.php
+++ b/lib/public/iconfig.php
@@ -109,6 +109,15 @@ interface IConfig {
 	 */
 	public function deleteAppValues($appName);
 
+	/**
+	 * Determines the apps that have the set the value for the specified
+	 * keys
+	 *
+	 * @param string $value the value to get the app for
+	 * @param string $key the key too lookup
+	 * @return array of app IDs
+	 */
+	public function getAppsForKeyValue($key, $value);
 
 	/**
 	 * Set a user defined value