fix: removed unused variable and check if tag ids are empty before starting the inserts

Signed-off-by: yemkareems <yemkareems@gmail.com>

1 files changed, 6 insertions, 1 deletions

diff --git a/lib/private/SystemTag/SystemTagObjectMapper.php b/lib/private/SystemTag/SystemTagObjectMapper.php
index cb24ad29a89..7a2e701515d 100644
--- a/lib/private/SystemTag/SystemTagObjectMapper.php
+++ b/lib/private/SystemTag/SystemTagObjectMapper.php
@@ -144,11 +144,16 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
 		$result = $query->executeQuery();
 		$rows = $result->fetchAll();
 		$existingTags = [];
-		foreach ($rows as $k => $row) {
+		foreach ($rows as $row) {
 			$existingTags[] = $row['systemtagid'];
 		}
 		//filter only tags that do not exist in db
 		$tagIds = array_diff($tagIds, $existingTags);
+		if (empty($tagIds)) {
+			// no tags to insert so return here
+			$this->connection->commit();
+			return;
+		}
 
 		$query = $this->connection->getQueryBuilder();
 		$query->insert(self::RELATION_TABLE)