aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorThomas Müller <thomas.mueller@tmit.eu>2015-09-14 17:59:52 +0200
committerThomas Müller <thomas.mueller@tmit.eu>2015-09-14 17:59:52 +0200
commitfb9e75edb6d01729a27c84f6f11399a1b0fde9f3 (patch)
treee10cc5ba04beecae732e907e65051dae2e95cdda /lib
parent4a777d686bd1bffb32ab6a52d479fe3a7bb33c4f (diff)
parent2d0f0e898dfe36d1c2d4919b772a0c886317274b (diff)
downloadnextcloud-server-fb9e75edb6d01729a27c84f6f11399a1b0fde9f3.tar.gz
nextcloud-server-fb9e75edb6d01729a27c84f6f11399a1b0fde9f3.zip
Merge pull request #18973 from owncloud/try-fixing-app-config-on-oracle
Do not compare the value on Oracle
Diffstat (limited to 'lib')
-rw-r--r--lib/private/appconfig.php16
1 files changed, 13 insertions, 3 deletions
diff --git a/lib/private/appconfig.php b/lib/private/appconfig.php
index 7ee64980fd0..cf2a057f224 100644
--- a/lib/private/appconfig.php
+++ b/lib/private/appconfig.php
@@ -175,11 +175,21 @@ class AppConfig implements IAppConfig {
->set('configvalue', $sql->createParameter('configvalue'))
->where($sql->expr()->eq('appid', $sql->createParameter('app')))
->andWhere($sql->expr()->eq('configkey', $sql->createParameter('configkey')))
- ->andWhere($sql->expr()->neq('configvalue', $sql->createParameter('configvalue')))
->setParameter('configvalue', $value)
->setParameter('app', $app)
- ->setParameter('configkey', $key)
- ->setParameter('configvalue', $value);
+ ->setParameter('configkey', $key);
+
+ /*
+ * Only limit to the existing value for non-Oracle DBs:
+ * http://docs.oracle.com/cd/E11882_01/server.112/e26088/conditions002.htm#i1033286
+ * > Large objects (LOBs) are not supported in comparison conditions.
+ */
+ if (!($this->conn instanceof \OC\DB\OracleConnection)) {
+ // Only update the value when it is not the same
+ $sql->andWhere($sql->expr()->neq('configvalue', $sql->createParameter('configvalue')))
+ ->setParameter('configvalue', $value);
+ }
+
$changedRow = (bool) $sql->execute();
$this->cache[$app][$key] = $value;