summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDaniel Kesselberg <mail@danielkesselberg.de>2019-05-26 15:50:56 +0200
committerDaniel Kesselberg <mail@danielkesselberg.de>2019-05-26 15:52:19 +0200
commitd00566b7501fac15e01ace70e148d1deebcc6f0c (patch)
tree921abc1a89652afbf47770268c4ca3203d5b0848 /lib
parent09974ae92d6f3bc20143dab43baef9fc75139585 (diff)
downloadnextcloud-server-d00566b7501fac15e01ace70e148d1deebcc6f0c.tar.gz
nextcloud-server-d00566b7501fac15e01ace70e148d1deebcc6f0c.zip
Don't notify admins if no potentially over exposing links found
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Diffstat (limited to 'lib')
-rw-r--r--lib/private/Repair/RemoveLinkShares.php14
1 files changed, 7 insertions, 7 deletions
diff --git a/lib/private/Repair/RemoveLinkShares.php b/lib/private/Repair/RemoveLinkShares.php
index 55b5a7c1fae..dd020dae502 100644
--- a/lib/private/Repair/RemoveLinkShares.php
+++ b/lib/private/Repair/RemoveLinkShares.php
@@ -201,8 +201,7 @@ class RemoveLinkShares implements IRepairStep {
}
}
- private function repair(IOutput $output): void {
- $total = $this->getTotal();
+ private function repair(IOutput $output, int $total): void {
$output->startProgress($total);
$shareCursor = $this->getShares();
@@ -225,12 +224,13 @@ class RemoveLinkShares implements IRepairStep {
}
public function run(IOutput $output): void {
- if ($this->shouldRun()) {
- $output->info('Removing potentially over exposing link shares');
- $this->repair($output);
- $output->info('Removed potentially over exposing link shares');
- } else {
+ if ($this->shouldRun() === false || ($total = $this->getTotal()) === 0) {
$output->info('No need to remove link shares.');
+ return;
}
+
+ $output->info('Removing potentially over exposing link shares');
+ $this->repair($output, $total);
+ $output->info('Removed potentially over exposing link shares');
}
}