Merge pull request #18878 from nextcloud/backport/18805/stable18

[stable18] Check if file already exists during file creation

1 files changed, 13 insertions, 7 deletions

diff --git a/lib/private/DirectEditing/Manager.php b/lib/private/DirectEditing/Manager.php
index a514eaea482..ebca819eeae 100644
--- a/lib/private/DirectEditing/Manager.php
+++ b/lib/private/DirectEditing/Manager.php
@@ -123,15 +123,21 @@ class Manager implements IManager {
 
 	public function create(string $path, string $editorId, string $creatorId, $templateId = null): string {
 		$userFolder = $this->rootFolder->getUserFolder($this->userId);
-		$file = $userFolder->newFile($path);
-		$editor = $this->getEditor($editorId);
-		$creators = $editor->getCreators();
-		foreach ($creators as $creator) {
-			if ($creator->getId() === $creatorId) {
-				$creator->create($file, $creatorId, $templateId);
-				return $this->createToken($editorId, $file, $path);
+		try {
+			$file = $userFolder->get($path);
+			throw new \RuntimeException('File already exists');
+		} catch (\OCP\Files\NotFoundException $e) {
+			$file = $userFolder->newFile($path);
+			$editor = $this->getEditor($editorId);
+			$creators = $editor->getCreators();
+			foreach ($creators as $creator) {
+				if ($creator->getId() === $creatorId) {
+					$creator->create($file, $creatorId, $templateId);
+					return $this->createToken($editorId, $file, $path);
+				}
 			}
 		}
+
 		throw new \RuntimeException('No creator found');
 	}