Made AvatarManager string and add return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

2 files changed, 8 insertions, 5 deletions

diff --git a/lib/private/AvatarManager.php b/lib/private/AvatarManager.php
index b8c6c2a1eb6..dea7f5f3a07 100644
--- a/lib/private/AvatarManager.php
+++ b/lib/private/AvatarManager.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * @copyright Copyright (c) 2016, ownCloud, Inc.
  *
@@ -29,6 +30,7 @@ namespace OC;
 
 use OCP\Files\IAppData;
 use OCP\Files\NotFoundException;
+use OCP\IAvatar;
 use OCP\IAvatarManager;
 use OCP\IConfig;
 use OCP\ILogger;
@@ -85,9 +87,9 @@ class AvatarManager implements IAvatarManager {
 	 * @throws \Exception In case the username is potentially dangerous
 	 * @throws NotFoundException In case there is no user folder yet
 	 */
-	public function getAvatar($userId) {
+	public function getAvatar(string $userId) : IAvatar {
 		$user = $this->userManager->get($userId);
-		if (is_null($user)) {
+		if ($user === null) {
 			throw new \Exception('user does not exist');
 		}
 
diff --git a/lib/public/IAvatarManager.php b/lib/public/IAvatarManager.php
index 04f4cd00d0d..19e4b93503a 100644
--- a/lib/public/IAvatarManager.php
+++ b/lib/public/IAvatarManager.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * @copyright Copyright (c) 2016, ownCloud, Inc.
  *
@@ -35,12 +36,12 @@ interface IAvatarManager {
 
 	/**
 	 * return a user specific instance of \OCP\IAvatar
-	 * @see \OCP\IAvatar
+	 * @see IAvatar
 	 * @param string $user the ownCloud user id
-	 * @return \OCP\IAvatar
+	 * @return IAvatar
 	 * @throws \Exception In case the username is potentially dangerous
 	 * @throws \OCP\Files\NotFoundException In case there is no user folder yet
 	 * @since 6.0.0
 	 */
-	public function getAvatar($user);
+	public function getAvatar(string $user) : IAvatar;
 }