diff options
| author | Lukas Reschke <lukas@owncloud.com> | 2015-01-19 11:56:04 +0100 |
|---|---|---|
| committer | Lukas Reschke <lukas@owncloud.com> | 2015-03-02 19:07:46 +0100 |
| commit | bbd5f2841561911461d992483cab54f5c18fa342 (patch) | |
| tree | 113e9ab1919c8fb42a7fd90db79139b783a643c9 /settings/admin.php | |
| parent | 1155ad6e389e47e110a415f22eddda1570dc9ff2 (diff) | |
| download | nextcloud-server-bbd5f2841561911461d992483cab54f5c18fa342.tar.gz nextcloud-server-bbd5f2841561911461d992483cab54f5c18fa342.zip | |
Let users configure security headers in their Webserver
Doing this in the PHP code is not the right approach for multiple reasons:
1. A bug in the PHP code prevents them from being added to the response.
2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud)
3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations.
This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.
Diffstat (limited to 'settings/admin.php')
| -rw-r--r-- | settings/admin.php | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/settings/admin.php b/settings/admin.php index 95940db7282..da25ab55a93 100644 --- a/settings/admin.php +++ b/settings/admin.php @@ -58,11 +58,6 @@ $excludedGroupsList = $appConfig->getValue('core', 'shareapi_exclude_groups_list $excludedGroupsList = explode(',', $excludedGroupsList); // FIXME: this should be JSON! $template->assign('shareExcludedGroupsList', implode('|', $excludedGroupsList)); -// Check if connected using HTTPS -$template->assign('isConnectedViaHTTPS', $request->getServerProtocol() === 'https'); -$template->assign('enforceHTTPSEnabled', $config->getSystemValue('forcessl', false)); -$template->assign('forceSSLforSubdomainsEnabled', $config->getSystemValue('forceSSLforSubdomains', false)); - // If the current web root is non-empty but the web root from the config is, // and system cron is used, the URL generator fails to build valid URLs. $shouldSuggestOverwriteCliUrl = $config->getAppValue('core', 'backgroundjobs_mode', 'ajax') === 'cron' && |