Modularize get(), async getAvatar, avatars @ usermgmt

And other small improvements

3 files changed, 14 insertions, 2 deletions

diff --git a/settings/templates/admin.php b/settings/templates/admin.php
index a166aec7775..e5b941f2b2f 100644
--- a/settings/templates/admin.php
+++ b/settings/templates/admin.php
@@ -128,6 +128,9 @@ if (!$_['internetconnectionworking']) {
 				<label for="avatar_gravatar">Gravatar</label><br>
 				<em><?php print_unescaped($l->t('Use <a href="http://gravatar.com/">gravatar</a> for avatars')); ?></em><br>
 				<em><?php p($l->t('This sends data to gravatar')); ?></em>
+				<?php if (!$_['internetconnectionworking']): ?>
+				<br><em><?php p($l->t('Gravatar needs an internet connection!')); ?></em>
+				<?php endif; ?>
 			</td>
 		</tr>
 		<tr>
diff --git a/settings/templates/personal.php b/settings/templates/personal.php
index 55f626aa574..01415a6f9a1 100644
--- a/settings/templates/personal.php
+++ b/settings/templates/personal.php
@@ -87,8 +87,11 @@ if($_['passwordChangeSupported']) {
 <form id="avatar">
 	<fieldset class="personalblock">
 		<legend><strong><?php p($l->t('Avatar')); ?></strong></legend>
-		<img src="<?php print_unescaped(\OC_Avatar::get(\OC_User::getUser())); ?>"><br>
-		<button><?php p($l->t('Upload a new avatar')); ?></button>
+		<img src="<?php print_unescaped(\OC_Avatar::get(\OC_User::getUser(), 128)); ?>"><br>
+		<em><?php p($l->t('Your avatar has to be a square and either a PNG or JPG image')); ?></em><br>
+		<div class="inlineblock button" id="uploadavatar"><?php p($l->t('Upload a new avatar')); ?></div>
+		<div class="inlineblock button" id="selectavatar"><?php p($l->t('Select a new avatar from your files')); ?></div>
+		<div class="inlineblock button" id="removeavatar"><?php p($l->t('Remove my avatar')); ?></div>
 	</fieldset>
 </form>
 <?php endif; ?>
diff --git a/settings/templates/users.php b/settings/templates/users.php
index 22450fdf25f..81d9a46d89d 100644
--- a/settings/templates/users.php
+++ b/settings/templates/users.php
@@ -81,6 +81,9 @@ $_['subadmingroups'] = array_flip($items);
 <table class="hascontrols" data-groups="<?php p(json_encode($allGroups));?>">
 	<thead>
 		<tr>
+			<?php if(\OC_Avatar::getMode() !== "none"): ?>
+				<th id='headerAvatar'><?php p($l->t('Avatar')); ?></th>
+			<?php endif; ?>
 			<th id='headerName'><?php p($l->t('Username'))?></th>
 			<th id="headerDisplayName"><?php p($l->t( 'Display Name' )); ?></th>
 			<th id="headerPassword"><?php p($l->t( 'Password' )); ?></th>
@@ -96,6 +99,9 @@ $_['subadmingroups'] = array_flip($items);
 		<?php foreach($_["users"] as $user): ?>
 		<tr data-uid="<?php p($user["name"]) ?>"
 			data-displayName="<?php p($user["displayName"]) ?>">
+			<?php if(\OC_Avatar::getMode() !== "none"): ?>
+				<td class="avatar"><img src="<?php p($user["avatar"]); ?>"></td>
+			<?php endif; ?>
 			<td class="name"><?php p($user["name"]); ?></td>
 			<td class="displayName"><span><?php p($user["displayName"]); ?></span> <img class="svg action"
 				src="<?php p(image_path('core', 'actions/rename.svg'))?>"