Merge all setup checks into one controller

* renamed hasMissingIndexes to missingIndexes

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

1 files changed, 1 insertions, 121 deletions

diff --git a/settings/templates/settings/admin/overview.php b/settings/templates/settings/admin/overview.php
index 5fb5e110eb1..cf725d3101e 100644
--- a/settings/templates/settings/admin/overview.php
+++ b/settings/templates/settings/admin/overview.php
@@ -23,133 +23,13 @@
 
 /** @var \OCP\IL10N $l */
 /** @var array $_ */
+/** @var \OCP\Defaults $theme */
 
 ?>
 
 <div id="security-warning" class="section">
 	<h2><?php p($l->t('Security & setup warnings'));?></h2>
 	<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.'));?></p>
-	<ul>
-		<?php
-		// is php setup properly to query system environment variables like getenv('PATH')
-		if ($_['getenvServerNotWorking']) {
-			?>
-			<li>
-				<?php p($l->t('PHP does not seem to be setup properly to query system environment variables. The test with getenv("PATH") only returns an empty response.')); ?><br>
-				<?php print_unescaped($l->t('Please check the <a target="_blank" rel="noreferrer noopener" href="%s">installation documentation ↗</a> for PHP configuration notes and the PHP configuration of your server, especially when using php-fpm.', link_to_docs('admin-php-fpm'))); ?>
-			</li>
-			<?php
-		}
-
-		// is read only config enabled
-		if ($_['readOnlyConfigEnabled']) {
-			?>
-			<li>
-				<?php p($l->t('The Read-Only config has been enabled. This prevents setting some configurations via the web-interface. Furthermore, the file needs to be made writable manually for every update.')); ?>
-			</li>
-			<?php
-		}
-
-		// Are doc blocks accessible?
-		if (!$_['isAnnotationsWorking']) {
-			?>
-			<li>
-				<?php p($l->t('PHP is apparently set up to strip inline doc blocks. This will make several core apps inaccessible.')); ?><br>
-				<?php p($l->t('This is probably caused by a cache/accelerator such as Zend OPcache or eAccelerator.')); ?>
-			</li>
-			<?php
-		}
-
-		// Is the Transaction isolation level READ_COMMITTED?
-		if ($_['invalidTransactionIsolationLevel']) {
-			?>
-			<li>
-				<?php p($l->t('Your database does not run with "READ COMMITTED" transaction isolation level. This can cause problems when multiple actions are executed in parallel.')); ?>
-			</li>
-			<?php
-		}
-
-		// Warning if memcache is outdated
-		foreach ($_['OutdatedCacheWarning'] as $php_module => $data) {
-			?>
-			<li>
-				<?php p($l->t('%1$s below version %2$s is installed, for stability and performance reasons it is recommended to update to a newer %1$s version.', $data)); ?>
-			</li>
-			<?php
-		}
-
-		// if module fileinfo available?
-		if (!$_['has_fileinfo']) {
-			?>
-			<li>
-				<?php p($l->t('The PHP module \'fileinfo\' is missing. It is strongly recommended to enable this module to get the best results with MIME type detection.')); ?>
-			</li>
-			<?php
-		}
-
-		// locking configured optimally?
-		if ($_['fileLockingType'] === 'none') {
-			?>
-			<li>
-				<?php print_unescaped($l->t('Transactional file locking is disabled, this might lead to issues with race conditions. Enable \'filelocking.enabled\' in config.php to avoid these problems. See the <a target="_blank" rel="noreferrer noopener" href="%s">documentation ↗</a> for more information.', link_to_docs('admin-transactional-locking'))); ?>
-			</li>
-			<?php
-		}
-
-		// is locale working ?
-		if (!$_['isLocaleWorking']) {
-			?>
-			<li>
-				<?php
-				$locales = 'en_US.UTF-8/fr_FR.UTF-8/es_ES.UTF-8/de_DE.UTF-8/ru_RU.UTF-8/pt_BR.UTF-8/it_IT.UTF-8/ja_JP.UTF-8/zh_CN.UTF-8';
-				p($l->t('System locale can not be set to a one which supports UTF-8.'));
-				?>
-				<br>
-				<?php
-				p($l->t('This means that there might be problems with certain characters in filenames.'));
-				?>
-				<br>
-				<?php
-				p($l->t('It is strongly proposed to install the required packages on your system to support one of the following locales: %s.', [$locales]));
-				?>
-			</li>
-			<?php
-		}
-
-		if ($_['suggestedOverwriteCliUrl']) {
-			?>
-			<li>
-				<?php p($l->t('If your installation is not installed at the root of the domain and uses system Cron, there can be issues with the URL generation. To avoid these problems, please set the "overwrite.cli.url" option in your config.php file to the webroot path of your installation (Suggested: "%s")', $_['suggestedOverwriteCliUrl'])); ?>
-			</li>
-			<?php
-		}
-
-		if ($_['cronErrors']) {
-			?>
-			<li>
-				<?php p($l->t('It was not possible to execute the cron job via CLI. The following technical errors have appeared:')); ?>
-				<br>
-				<ol>
-					<?php foreach(json_decode($_['cronErrors']) as $error) { if(isset($error->error)) {?>
-						<li><?php p($error->error) ?> <?php p($error->hint) ?></li>
-					<?php }} ?>
-				</ol>
-			</li>
-			<?php
-		}
-		?>
-		<?php if ($_['lastcron'] !== false):
-				$relative_time = relative_modified_date($_['lastcron']);
-				$formatter = \OC::$server->getDateTimeFormatter();
-				$absolute_time = $formatter->formatDateTime($_['lastcron'], 'long', 'long');
-				if (time() - $_['lastcron'] > 3600): ?>
-					<li class="crondate" title="<?php p($absolute_time);?>">
-						<?php p($l->t("Last background job execution ran %s. Something seems wrong.", [$relative_time]));?>
-						<a href="<?php p(\OC::$server->getURLGenerator()->linkToRoute('settings.AdminSettings.index', ['section' => 'server'])); ?>#backgroundjobs"><?php p($l->t('Check the background job settings')); ?></a>
-					</li>
-				<?php endif; ?>
-			<?php endif; ?>
-	</ul>
 
 	<div id="security-warning-state-ok" class="hidden">
 		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.'));?></span>