diff options
| author | Lukas Reschke <lukas@statuscode.ch> | 2021-09-07 10:44:34 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-07 10:44:34 +0200 |
| commit | c21a721fc16a815fc4fe61423dccae4f22a6c894 (patch) | |
| tree | c3cc82dea0dc9e6d6e05b859c61c530d17872852 /tests/Core | |
| parent | b79f1eb6aed3e1cef057e07d0388de237e415a35 (diff) | |
| parent | 8da6a9bea9d4965ab6617b362ba9195f1c3fd5d4 (diff) | |
| download | nextcloud-server-c21a721fc16a815fc4fe61423dccae4f22a6c894.tar.gz nextcloud-server-c21a721fc16a815fc4fe61423dccae4f22a6c894.zip | |
Merge pull request #28725 from nextcloud/disallow-public-page-in-2fa-flow
Remove 2FA exemption from PublicPage annotation
Diffstat (limited to 'tests/Core')
| -rw-r--r-- | tests/Core/Middleware/TwoFactorMiddlewareTest.php | 27 |
1 files changed, 0 insertions, 27 deletions
diff --git a/tests/Core/Middleware/TwoFactorMiddlewareTest.php b/tests/Core/Middleware/TwoFactorMiddlewareTest.php index 5ef2b75fde6..8cc4340ad98 100644 --- a/tests/Core/Middleware/TwoFactorMiddlewareTest.php +++ b/tests/Core/Middleware/TwoFactorMiddlewareTest.php @@ -97,10 +97,6 @@ class TwoFactorMiddlewareTest extends TestCase { } public function testBeforeControllerNotLoggedIn() { - $this->reflector->expects($this->once()) - ->method('hasAnnotation') - ->with('PublicPage') - ->willReturn(false); $this->userSession->expects($this->once()) ->method('isLoggedIn') ->willReturn(false); @@ -111,24 +107,9 @@ class TwoFactorMiddlewareTest extends TestCase { $this->middleware->beforeController($this->controller, 'index'); } - public function testBeforeControllerPublicPage() { - $this->reflector->expects($this->once()) - ->method('hasAnnotation') - ->with('PublicPage') - ->willReturn(true); - $this->userSession->expects($this->never()) - ->method('isLoggedIn'); - - $this->middleware->beforeController($this->controller, 'create'); - } - public function testBeforeSetupController() { $user = $this->createMock(IUser::class); $controller = $this->createMock(ALoginSetupController::class); - $this->reflector->expects($this->once()) - ->method('hasAnnotation') - ->with('PublicPage') - ->willReturn(false); $this->userSession->expects($this->any()) ->method('getUser') ->willReturn($user); @@ -144,10 +125,6 @@ class TwoFactorMiddlewareTest extends TestCase { public function testBeforeControllerNoTwoFactorCheckNeeded() { $user = $this->createMock(IUser::class); - $this->reflector->expects($this->once()) - ->method('hasAnnotation') - ->with('PublicPage') - ->willReturn(false); $this->userSession->expects($this->once()) ->method('isLoggedIn') ->willReturn(true); @@ -168,10 +145,6 @@ class TwoFactorMiddlewareTest extends TestCase { $user = $this->createMock(IUser::class); - $this->reflector->expects($this->once()) - ->method('hasAnnotation') - ->with('PublicPage') - ->willReturn(false); $this->userSession->expects($this->once()) ->method('isLoggedIn') ->willReturn(true); |