Improve sharing flow

This commit introduces the following changes:

- Does not create new share once user is selected for internal shares
- Adds a `SharingDetails` view for share configurations
- Adds a quick share select to enable fast changes in share permisions.

Resolves: https://github.com/nextcloud/server/issues/26691

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>

1 files changed, 0 insertions, 485 deletions

diff --git a/tests/acceptance/features/app-files-sharing.feature b/tests/acceptance/features/app-files-sharing.feature
deleted file mode 100644
index 0ad01e05dad..00000000000
--- a/tests/acceptance/features/app-files-sharing.feature
+++ /dev/null
@@ -1,485 +0,0 @@
-Feature: app-files-sharing
-
-  Scenario: share a file with another user
-    Given I act as John
-    And I am logged in as the admin
-    And I act as Jane
-    And I am logged in
-    And I act as John
-    And I rename "welcome.txt" to "farewell.txt"
-    And I see that the file list contains a file named "farewell.txt"
-    When I share "farewell.txt" with "user0"
-    And I see that the file is shared with "user0"
-    And I act as Jane
-    # The Files app is open again to reload the file list
-    And I open the Files app
-    Then I see that the file list contains a file named "farewell.txt"
-    And I open the details view for "farewell.txt"
-    And I see that the details view is open
-    And I open the "Sharing" tab in the details view
-    And I see that the "Sharing" tab in the details view is eventually loaded
-    And I see that the file is shared with me by "admin"
-
-#  Scenario: share a file with another user that needs to accept shares
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I visit the settings page
-#    And I open the "Sharing" section
-#    And I disable accepting the shares by default
-#    And I see that shares are not accepted by default
-#    And I act as John
-#    And I rename "welcome.txt" to "farewell.txt"
-#    And I see that the file list contains a file named "farewell.txt"
-#    When I share "farewell.txt" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    And I open the Files app
-#    And I see that the file list does not contain a file named "farewell.txt"
-#    And I accept the share for "/farewell.txt" in the notifications
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "farewell.txt"
-#    And I open the details view for "farewell.txt"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#
-#  Scenario: share a file with another user who already has a file with that name
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    When I share "welcome.txt" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "welcome (2).txt"
-#    And I open the details view for "welcome (2).txt"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#
-#  Scenario: share a skeleton file with another user before first login
-#    # If a file is shared with a user before her first login the skeleton would
-#    # not have been created, so if the shared file has the same name as one from
-#    # the skeleton the shared file will take its place and the skeleton file
-#    # will not be added.
-#    Given I act as John
-#    And I am logged in as the admin
-#    When I share "welcome.txt" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    And I am logged in
-#    Then I see that the file list contains a file named "welcome.txt"
-#    And I open the details view for "welcome.txt"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#
-#  Scenario: reshare a file with another user
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as Jim
-#    And I am logged in as "user1"
-#    And I act as John
-#    And I rename "welcome.txt" to "farewell.txt"
-#    And I see that the file list contains a file named "farewell.txt"
-#    And I share "farewell.txt" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    When I share "farewell.txt" with "user1"
-#    And I see that the file is shared with "user1"
-#    And I act as Jim
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "farewell.txt"
-#    And I open the details view for "farewell.txt"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "user0"
-#
-#  Scenario: owner sees reshares with other users
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I rename "welcome.txt" to "farewell.txt"
-#    And I see that the file list contains a file named "farewell.txt"
-#    And I share "farewell.txt" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "farewell.txt" with "user1"
-#    And I see that the file is shared with "user1"
-#    When I act as John
-#    # The Files app is open again to reload the file list and the shares
-#    And I open the Files app
-#    And I open the details view for "farewell.txt"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    Then I see that the file is shared with "user0"
-#    And I see that the file is shared with "user1"
-#
-#  Scenario: share an empty folder with another user
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    When I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "Shared folder"
-#    And I open the details view for "Shared folder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#
-#  Scenario: sharee sees a folder created by the owner in a shared folder
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I enter in the folder named "Shared folder"
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    Then I see that the file list contains a file named "Subfolder"
-#
-#  Scenario: owner sees a folder created by the sharee in a shared folder
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as John
-#    And I enter in the folder named "Shared folder"
-#    Then I see that the file list contains a file named "Subfolder"
-#
-#  Scenario: resharee sees a folder created by the owner in a shared folder
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as Jim
-#    And I am logged in as "user1"
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "Shared folder" with "user1"
-#    And I act as John
-#    And I enter in the folder named "Shared folder"
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as Jim
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    Then I see that the file list contains a file named "Subfolder"
-#
-#  Scenario: owner sees a folder created by the resharee in a shared folder
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as Jim
-#    And I am logged in as "user1"
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "Shared folder" with "user1"
-#    And I act as Jim
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as John
-#    And I enter in the folder named "Shared folder"
-#    Then I see that the file list contains a file named "Subfolder"
-#
-#  Scenario: sharer does not see resharing option for a folder if resharing is disabled in the settings after the share is created
-#    Given I am logged in as the admin
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    When I visit the admin settings page
-#    And I open the "Sharing" section of the "Administration" group
-#    And I disable resharing
-#    And I see that resharing is disabled
-#    Then I open the Files app
-#    And I open the details view for "Shared folder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that resharing for "user0" is not available
-#
-#  Scenario: sharee can not reshare a folder if resharing is disabled in the settings after the share is created
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I visit the admin settings page
-#    And I open the "Sharing" section of the "Administration" group
-#    And I disable resharing
-#    And I see that resharing is disabled
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "Shared folder"
-#    And I open the details view for "Shared folder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#    And I see that resharing the file is not allowed
-#
-#  Scenario: sharee can unshare a folder if resharing is disabled in the settings after the share is created
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "Shared folder" with "user1"
-#    And I act as John
-#    And I visit the admin settings page
-#    And I open the "Sharing" section of the "Administration" group
-#    And I disable resharing
-#    And I see that resharing is disabled
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "Shared folder"
-#    And I open the details view for "Shared folder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#    And I unshare the share with "user1"
-#    And I see that the file is not shared with "user1"
-#
-#  Scenario: resharee sees a folder created by the owner in a shared folder if resharing is disabled in the settings after the share is created
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as Jim
-#    And I am logged in as "user1"
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "Shared folder" with "user1"
-#    And I act as John
-#    And I visit the admin settings page
-#    And I open the "Sharing" section of the "Administration" group
-#    And I disable resharing
-#    And I see that resharing is disabled
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as Jim
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    Then I see that the file list contains a file named "Subfolder"
-#
-#  Scenario: sharee can not reshare a folder if the sharer disables it
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I set the share with "user0" as not reshareable
-#    And I see that "user0" can not reshare the share
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    Then I see that the file list contains a file named "Shared folder"
-#    And I open the details view for "Shared folder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that the file is shared with me by "admin"
-#    And I see that resharing the file is not allowed
-#
-#  Scenario: sharee can not reshare a subfolder if the sharer disables it for the parent folder
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I set the share with "user0" as not reshareable
-#    And I see that "user0" can not reshare the share
-#    And I enter in the folder named "Shared folder"
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    Then I see that the file list contains a file named "Subfolder"
-#    And I open the details view for "Subfolder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I see that resharing the file is not allowed
-#
-#  Scenario: sharee can not reshare a file with edit permission if the sharer disables it
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I rename "welcome.txt" to "farewell.txt"
-#    And I see that the file list contains a file named "farewell.txt"
-#    And I share "farewell.txt" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I set the share with "user0" as not editable
-#    And I see that "user0" can not edit the share
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "farewell.txt" with "user1"
-#    Then I see that the file is shared with "user1"
-#    And I see that "user1" can not edit the share
-#    And I see that "user1" can not be allowed to edit the share
-
-# TODO: disabled unreliable test
-#  Scenario: sharee can not reshare a folder with create permission if the sharer disables it
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I set the share with "user0" as not creatable
-#    And I see that "user0" can not create in the share
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "Shared folder" with "user1"
-#    Then I see that the file is shared with "user1"
-#    And I see that "user1" can not create in the share
-#    And I see that "user1" can not be allowed to create in the share
-
-# TODO: disabled unreliable test
-#  Scenario: sharee can revoke create permission from reshare after the sharer disabled it
-#    Given I act as John
-#    And I am logged in as the admin
-#    And I act as Jane
-#    And I am logged in
-#    And I act as Jim
-#    And I am logged in as "user1"
-#    And I act as John
-#    And I create a new folder named "Shared folder"
-#    And I see that the file list contains a file named "Shared folder"
-#    And I share "Shared folder" with "user0"
-#    And I see that the file is shared with "user0"
-#    And I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I share "Shared folder" with "user1"
-#    And I see that the file is shared with "user1"
-#    And I act as John
-#    And I set the share with "user0" as not creatable
-#    And I see that "user0" can not create in the share
-#    And I act as Jim
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    # Creation is still allowed in already created reshares
-#    And I create a new folder named "Subfolder"
-#    And I see that the file list contains a file named "Subfolder"
-#    When I act as Jane
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I open the details view for "Shared folder"
-#    And I see that the details view is open
-#    And I open the "Sharing" tab in the details view
-#    And I see that the "Sharing" tab in the details view is eventually loaded
-#    And I set the share with "user1" as not creatable
-#    Then I see that "user1" can not create in the share
-#    And I see that "user1" can not be allowed to create in the share
-#    And I act as Jim
-#    # The Files app is open again to reload the file list
-#    And I open the Files app
-#    And I enter in the folder named "Shared folder"
-#    And I see that it is not possible to create new files