diff options
author | Lukas Reschke <lukas@statuscode.ch> | 2017-08-01 17:32:03 +0200 |
---|---|---|
committer | Lukas Reschke <lukas@statuscode.ch> | 2017-08-01 17:32:03 +0200 |
commit | f93a82b8b09109e391b0314f92d02d285c356ad6 (patch) | |
tree | c85246eadd2103200e26af6b208756dc87822e76 /tests/lib/AppFramework | |
parent | 84c22fdeef6986f9038d8563937cc234751d5147 (diff) | |
download | nextcloud-server-f93a82b8b09109e391b0314f92d02d285c356ad6.tar.gz nextcloud-server-f93a82b8b09109e391b0314f92d02d285c356ad6.zip |
Remove explicit type hints for Controller
This is public API and breaks the middlewares of existing apps. Since this also requires maintaining two different code paths for 12 and 13 I'm at the moment voting for reverting this change.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Diffstat (limited to 'tests/lib/AppFramework')
-rw-r--r-- | tests/lib/AppFramework/Middleware/MiddlewareDispatcherTest.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/lib/AppFramework/Middleware/MiddlewareDispatcherTest.php b/tests/lib/AppFramework/Middleware/MiddlewareDispatcherTest.php index 9eca127cb89..f948e184f53 100644 --- a/tests/lib/AppFramework/Middleware/MiddlewareDispatcherTest.php +++ b/tests/lib/AppFramework/Middleware/MiddlewareDispatcherTest.php @@ -62,7 +62,7 @@ class TestMiddleware extends Middleware { $this->beforeControllerThrowsEx = $beforeControllerThrowsEx; } - public function beforeController(Controller $controller, $methodName){ + public function beforeController($controller, $methodName){ self::$beforeControllerCalled++; $this->beforeControllerOrder = self::$beforeControllerCalled; $this->controller = $controller; @@ -72,7 +72,7 @@ class TestMiddleware extends Middleware { } } - public function afterException(Controller $controller, $methodName, \Exception $exception){ + public function afterException($controller, $methodName, \Exception $exception){ self::$afterExceptionCalled++; $this->afterExceptionOrder = self::$afterExceptionCalled; $this->controller = $controller; @@ -81,7 +81,7 @@ class TestMiddleware extends Middleware { parent::afterException($controller, $methodName, $exception); } - public function afterController(Controller $controller, $methodName, Response $response){ + public function afterController($controller, $methodName, Response $response){ self::$afterControllerCalled++; $this->afterControllerOrder = self::$afterControllerCalled; $this->controller = $controller; @@ -90,7 +90,7 @@ class TestMiddleware extends Middleware { return parent::afterController($controller, $methodName, $response); } - public function beforeOutput(Controller $controller, $methodName, $output){ + public function beforeOutput($controller, $methodName, $output){ self::$beforeOutputCalled++; $this->beforeOutputOrder = self::$beforeOutputCalled; $this->controller = $controller; |