Make 2FA providers stateful

This adds persistence to the Nextcloud server 2FA logic so that the server
knows which 2FA providers are enabled for a specific user at any time, even
when the provider is not available.

The `IStatefulProvider` interface was added as tagging interface for providers
that are compatible with this new API.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

1 files changed, 86 insertions, 0 deletions

diff --git a/tests/lib/Authentication/TwoFactorAuth/ProviderLoaderTest.php b/tests/lib/Authentication/TwoFactorAuth/ProviderLoaderTest.php
new file mode 100644
index 00000000000..6479e41fffb
--- /dev/null
+++ b/tests/lib/Authentication/TwoFactorAuth/ProviderLoaderTest.php
@@ -0,0 +1,86 @@
+<?php
+
+/**
+ * Created by PhpStorm.
+ * User: christoph
+ * Date: 04.06.18
+ * Time: 13:29
+ */
+
+namespace lib\Authentication\TwoFactorAuth;
+
+use Exception;
+use OC\Authentication\TwoFactorAuth\ProviderLoader;
+use OCP\App\IAppManager;
+use OCP\Authentication\TwoFactorAuth\IProvider;
+use PHPUnit_Framework_MockObject_MockObject;
+use Test\TestCase;
+
+class ProviderLoaderTest extends TestCase {
+
+	/** @var IAppManager|PHPUnit_Framework_MockObject_MockObject */
+	private $appManager;
+
+	/** @var IUser|PHPUnit_Framework_MockObject_MockObject */
+	private $user;
+
+	/** @var ProviderLoader */
+	private $loader;
+
+	protected function setUp() {
+		parent::setUp();
+
+		$this->appManager = $this->createMock(IAppManager::class);
+		$this->user = $this->createMock(\OCP\IUser::class);
+
+		$this->loader = new ProviderLoader($this->appManager);
+	}
+
+	/**
+	 * @expectedException Exception
+	 * @expectedExceptionMessage Could not load two-factor auth provider \OCA\MyFaulty2faApp\DoesNotExist
+	 */
+	public function testFailHardIfProviderCanNotBeLoaded() {
+		$this->appManager->expects($this->once())
+			->method('getEnabledAppsForUser')
+			->with($this->user)
+			->willReturn(['mail', 'twofactor_totp']);
+		$this->appManager
+			->method('getAppInfo')
+			->will($this->returnValueMap([
+				['mail', false, null, []],
+				['twofactor_totp', false, null, [
+					'two-factor-providers' => [
+						'\\OCA\\MyFaulty2faApp\\DoesNotExist',
+					],
+				]],
+			]));
+
+		$this->loader->getProviders($this->user);
+	}
+
+	public function testGetProviders() {
+		$provider = $this->createMock(IProvider::class);
+		$provider->method('getId')->willReturn('test');
+		\OC::$server->registerService('\\OCA\\TwoFactorTest\\Provider', function () use ($provider) {
+			return $provider;
+		});
+		$this->appManager->expects($this->once())
+			->method('getEnabledAppsForUser')
+			->with($this->user)
+			->willReturn(['twofactor_test']);
+		$this->appManager
+			->method('getAppInfo')
+			->with('twofactor_test')
+			->willReturn(['two-factor-providers' => [
+				'\\OCA\\TwoFactorTest\\Provider',
+			]]);
+
+		$providers = $this->loader->getProviders($this->user);
+
+		$this->assertCount(1, $providers);
+		$this->assertArrayHasKey('test', $providers);
+		$this->assertSame($provider, $providers['test']);
+	}
+
+}