diff options
| author | Morris Jobke <hey@morrisjobke.de> | 2020-07-23 13:36:49 +0200 |
|---|---|---|
| committer | Morris Jobke <hey@morrisjobke.de> | 2020-07-23 17:11:29 +0200 |
| commit | e4144e6b36eb874d73dd6d2282a0ac0f0ee1bd63 (patch) | |
| tree | 9baa7ddb161516a5936575023ac815543182565a /tests/lib/DB | |
| parent | 0123cd0ae345ae6c90955ea79331a48f7c5cf95d (diff) | |
| download | nextcloud-server-e4144e6b36eb874d73dd6d2282a0ac0f0ee1bd63.tar.gz nextcloud-server-e4144e6b36eb874d73dd6d2282a0ac0f0ee1bd63.zip | |
Remove deprecated test of internal attributes via assertAttributeEquals
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322
It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Diffstat (limited to 'tests/lib/DB')
| -rw-r--r-- | tests/lib/DB/DBSchemaTest.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/lib/DB/DBSchemaTest.php b/tests/lib/DB/DBSchemaTest.php index 4b249d07c45..9f575a75da6 100644 --- a/tests/lib/DB/DBSchemaTest.php +++ b/tests/lib/DB/DBSchemaTest.php @@ -83,8 +83,8 @@ class DBSchemaTest extends TestCase { $outfile = $this->tempManager->getTemporaryFile(); OC_DB::getDbStructure($outfile); $content = file_get_contents($outfile); - $this->assertContains($this->table1, $content); - $this->assertContains($this->table2, $content); + $this->assertStringContainsString($this->table1, $content); + $this->assertStringContainsString($this->table2, $content); } public function doTestSchemaRemoving() { |