Use the short array syntax, everywhere

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

8 files changed, 68 insertions, 68 deletions

diff --git a/tests/lib/Files/Storage/HomeTest.php b/tests/lib/Files/Storage/HomeTest.php
index 6075e9af293..d5feb40840f 100644
--- a/tests/lib/Files/Storage/HomeTest.php
+++ b/tests/lib/Files/Storage/HomeTest.php
@@ -73,7 +73,7 @@ class HomeTest extends Storage {
 		$this->tmpDir = \OC::$server->getTempManager()->getTemporaryFolder();
 		$this->userId = $this->getUniqueID('user_');
 		$this->user = new DummyUser($this->userId, $this->tmpDir);
-		$this->instance = new \OC\Files\Storage\Home(array('user' => $this->user));
+		$this->instance = new \OC\Files\Storage\Home(['user' => $this->user]);
 	}
 
 	protected function tearDown(): void {
diff --git a/tests/lib/Files/Storage/LocalTest.php b/tests/lib/Files/Storage/LocalTest.php
index 23738a25c2a..46784811248 100644
--- a/tests/lib/Files/Storage/LocalTest.php
+++ b/tests/lib/Files/Storage/LocalTest.php
@@ -39,7 +39,7 @@ class LocalTest extends Storage {
 		parent::setUp();
 
 		$this->tmpDir = \OC::$server->getTempManager()->getTemporaryFolder();
-		$this->instance = new \OC\Files\Storage\Local(array('datadir' => $this->tmpDir));
+		$this->instance = new \OC\Files\Storage\Local(['datadir' => $this->tmpDir]);
 	}
 
 	protected function tearDown(): void {
diff --git a/tests/lib/Files/Storage/Storage.php b/tests/lib/Files/Storage/Storage.php
index a25a3f74f9e..736cbfff4f0 100644
--- a/tests/lib/Files/Storage/Storage.php
+++ b/tests/lib/Files/Storage/Storage.php
@@ -80,13 +80,13 @@ abstract class Storage extends \Test\TestCase {
 		$this->assertTrue($this->instance->isUpdatable('/' . $directory));
 
 		$dh = $this->instance->opendir('/');
-		$content = array();
+		$content = [];
 		while ($file = readdir($dh)) {
 			if ($file != '.' and $file != '..') {
 				$content[] = $file;
 			}
 		}
-		$this->assertEquals(array($directory), $content);
+		$this->assertEquals([$directory], $content);
 
 		$this->assertFalse($this->instance->mkdir('/' . $directory)); //can't create existing folders
 		$this->assertTrue($this->instance->rmdir('/' . $directory));
@@ -97,13 +97,13 @@ abstract class Storage extends \Test\TestCase {
 		$this->assertFalse($this->instance->rmdir('/' . $directory)); //can't remove non existing folders
 
 		$dh = $this->instance->opendir('/');
-		$content = array();
+		$content = [];
 		while ($file = readdir($dh)) {
 			if ($file != '.' and $file != '..') {
 				$content[] = $file;
 			}
 		}
-		$this->assertEquals(array(), $content);
+		$this->assertEquals([], $content);
 	}
 
 	public function fileNameProvider() {
@@ -130,12 +130,12 @@ abstract class Storage extends \Test\TestCase {
 
 	function loremFileProvider() {
 		$root = \OC::$SERVERROOT . '/tests/data/';
-		return array(
+		return [
 			// small file
-			array($root . 'lorem.txt'),
+			[$root . 'lorem.txt'],
 			// bigger file (> 8 KB which is the standard PHP block size)
-			array($root . 'lorem-big.txt')
-		);
+			[$root . 'lorem-big.txt']
+		];
 	}
 
 	/**
@@ -413,11 +413,11 @@ abstract class Storage extends \Test\TestCase {
 	}
 
 	public function hashProvider() {
-		return array(
-			array('Foobar', 'md5'),
-			array('Foobar', 'sha1'),
-			array('Foobar', 'sha256'),
-		);
+		return [
+			['Foobar', 'md5'],
+			['Foobar', 'sha1'],
+			['Foobar', 'sha256'],
+		];
 	}
 
 	/**
@@ -438,14 +438,14 @@ abstract class Storage extends \Test\TestCase {
 		$this->assertEquals('data', $this->instance->file_get_contents('#foo/test.txt'));
 
 		$dh = $this->instance->opendir('#foo');
-		$content = array();
+		$content = [];
 		while ($file = readdir($dh)) {
 			if ($file != '.' and $file != '..') {
 				$content[] = $file;
 			}
 		}
 
-		$this->assertEquals(array('test.txt'), $content);
+		$this->assertEquals(['test.txt'], $content);
 	}
 
 	public function testCopyOverWriteFile() {
diff --git a/tests/lib/Files/Storage/Wrapper/EncryptionTest.php b/tests/lib/Files/Storage/Wrapper/EncryptionTest.php
index a9d678e76e9..ac3880309c0 100644
--- a/tests/lib/Files/Storage/Wrapper/EncryptionTest.php
+++ b/tests/lib/Files/Storage/Wrapper/EncryptionTest.php
@@ -148,7 +148,7 @@ class EncryptionTest extends Storage {
 
 		$this->logger = $this->createMock(Log::class);
 
-		$this->sourceStorage = new Temporary(array());
+		$this->sourceStorage = new Temporary([]);
 
 		$this->keyStore = $this->getMockBuilder('\OC\Encryption\Keys\Storage')
 			->disableOriginalConstructor()->getMock();
@@ -458,13 +458,13 @@ class EncryptionTest extends Storage {
 	 * @return array
 	 */
 	public function dataTestCopyAndRename() {
-		return array(
-			array('source', 'target', true, false, false),
-			array('source', 'target', true, true, false),
-			array('source', '/subFolder/target', true, false, false),
-			array('source', '/subFolder/target', true, true, true),
-			array('source', '/subFolder/target', false, true, false),
-		);
+		return [
+			['source', 'target', true, false, false],
+			['source', 'target', true, true, false],
+			['source', '/subFolder/target', true, false, false],
+			['source', '/subFolder/target', true, true, true],
+			['source', '/subFolder/target', false, true, false],
+		];
 	}
 
 	public function testIsLocal() {
@@ -512,16 +512,16 @@ class EncryptionTest extends Storage {
 	}
 
 	public function dataTestRmdir() {
-		return array(
-			array('/file.txt', true, true, true),
-			array('/file.txt', false, true, true),
-			array('/file.txt', true, false, true),
-			array('/file.txt', false, false, true),
-			array('/file.txt', true, true, false),
-			array('/file.txt', false, true, false),
-			array('/file.txt', true, false, false),
-			array('/file.txt', false, false, false),
-		);
+		return [
+			['/file.txt', true, true, true],
+			['/file.txt', false, true, true],
+			['/file.txt', true, false, true],
+			['/file.txt', false, false, true],
+			['/file.txt', true, true, false],
+			['/file.txt', false, true, false],
+			['/file.txt', true, false, false],
+			['/file.txt', false, false, false],
+		];
 	}
 
 	/**
@@ -547,10 +547,10 @@ class EncryptionTest extends Storage {
 	}
 
 	public function dataTestCopyKeys() {
-		return array(
-			array(true, false),
-			array(false, true),
-		);
+		return [
+			[true, false],
+			[false, true],
+		];
 	}
 
 	/**
@@ -613,13 +613,13 @@ class EncryptionTest extends Storage {
 	}
 
 	public function dataTestGetHeader() {
-		return array(
-			array('/foo/bar.txt', false, '/foo/bar.txt'),
-			array('/foo/bar.txt.part', false, '/foo/bar.txt'),
-			array('/foo/bar.txt.ocTransferId7437493.part', false, '/foo/bar.txt'),
-			array('/foo/bar.txt.part', true, '/foo/bar.txt'),
-			array('/foo/bar.txt.ocTransferId7437493.part', true, '/foo/bar.txt'),
-		);
+		return [
+			['/foo/bar.txt', false, '/foo/bar.txt'],
+			['/foo/bar.txt.part', false, '/foo/bar.txt'],
+			['/foo/bar.txt.ocTransferId7437493.part', false, '/foo/bar.txt'],
+			['/foo/bar.txt.part', true, '/foo/bar.txt'],
+			['/foo/bar.txt.ocTransferId7437493.part', true, '/foo/bar.txt'],
+		];
 	}
 
 	/**
diff --git a/tests/lib/Files/Storage/Wrapper/JailTest.php b/tests/lib/Files/Storage/Wrapper/JailTest.php
index cb7003cb7ea..6c8905af765 100644
--- a/tests/lib/Files/Storage/Wrapper/JailTest.php
+++ b/tests/lib/Files/Storage/Wrapper/JailTest.php
@@ -17,24 +17,24 @@ class JailTest extends \Test\Files\Storage\Storage {
 
 	protected function setUp(): void {
 		parent::setUp();
-		$this->sourceStorage = new \OC\Files\Storage\Temporary(array());
+		$this->sourceStorage = new \OC\Files\Storage\Temporary([]);
 		$this->sourceStorage->mkdir('foo');
-		$this->instance = new \OC\Files\Storage\Wrapper\Jail(array(
+		$this->instance = new \OC\Files\Storage\Wrapper\Jail([
 			'storage' => $this->sourceStorage,
 			'root' => 'foo'
-		));
+		]);
 	}
 
 	protected function tearDown(): void {
 		// test that nothing outside our jail is touched
-		$contents = array();
+		$contents = [];
 		$dh = $this->sourceStorage->opendir('');
 		while ($file = readdir($dh)) {
 			if (!\OC\Files\Filesystem::isIgnoredDir($file)) {
 				$contents[] = $file;
 			}
 		}
-		$this->assertEquals(array('foo'), $contents);
+		$this->assertEquals(['foo'], $contents);
 		$this->sourceStorage->cleanUp();
 		parent::tearDown();
 	}
diff --git a/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php b/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php
index bfdd3d3ddbb..1e69ee7165e 100644
--- a/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php
+++ b/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php
@@ -24,7 +24,7 @@ class PermissionsMaskTest extends \Test\Files\Storage\Storage {
 
 	protected function setUp(): void {
 		parent::setUp();
-		$this->sourceStorage = new \OC\Files\Storage\Temporary(array());
+		$this->sourceStorage = new \OC\Files\Storage\Temporary([]);
 		$this->instance = $this->getMaskedStorage(Constants::PERMISSION_ALL);
 	}
 
@@ -34,10 +34,10 @@ class PermissionsMaskTest extends \Test\Files\Storage\Storage {
 	}
 
 	protected function getMaskedStorage($mask) {
-		return new \OC\Files\Storage\Wrapper\PermissionsMask(array(
+		return new \OC\Files\Storage\Wrapper\PermissionsMask([
 			'storage' => $this->sourceStorage,
 			'mask' => $mask
-		));
+		]);
 	}
 
 	public function testMkdirNoCreate() {
@@ -129,10 +129,10 @@ class PermissionsMaskTest extends \Test\Files\Storage\Storage {
 
 	public function testScanNewFilesNested() {
 		$storage = $this->getMaskedStorage(Constants::PERMISSION_READ + Constants::PERMISSION_CREATE + Constants::PERMISSION_UPDATE);
-		$nestedStorage = new \OC\Files\Storage\Wrapper\PermissionsMask(array(
+		$nestedStorage = new \OC\Files\Storage\Wrapper\PermissionsMask([
 			'storage' => $storage,
 			'mask' => Constants::PERMISSION_READ + Constants::PERMISSION_CREATE
-		));
+		]);
 		$wrappedStorage = new Wrapper(['storage' => $nestedStorage]);
 		$wrappedStorage->file_put_contents('foo', 'bar');
 		$wrappedStorage->getScanner()->scan('');
diff --git a/tests/lib/Files/Storage/Wrapper/QuotaTest.php b/tests/lib/Files/Storage/Wrapper/QuotaTest.php
index 164541b670c..65cfe30eb1c 100644
--- a/tests/lib/Files/Storage/Wrapper/QuotaTest.php
+++ b/tests/lib/Files/Storage/Wrapper/QuotaTest.php
@@ -31,8 +31,8 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 		parent::setUp();
 
 		$this->tmpDir = \OC::$server->getTempManager()->getTemporaryFolder();
-		$storage = new \OC\Files\Storage\Local(array('datadir' => $this->tmpDir));
-		$this->instance = new \OC\Files\Storage\Wrapper\Quota(array('storage' => $storage, 'quota' => 10000000));
+		$storage = new \OC\Files\Storage\Local(['datadir' => $this->tmpDir]);
+		$this->instance = new \OC\Files\Storage\Wrapper\Quota(['storage' => $storage, 'quota' => 10000000]);
 	}
 
 	protected function tearDown(): void {
@@ -44,10 +44,10 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 	 * @param integer $limit
 	 */
 	protected function getLimitedStorage($limit) {
-		$storage = new \OC\Files\Storage\Local(array('datadir' => $this->tmpDir));
+		$storage = new \OC\Files\Storage\Local(['datadir' => $this->tmpDir]);
 		$storage->mkdir('files');
 		$storage->getScanner()->scan('');
-		return new \OC\Files\Storage\Wrapper\Quota(array('storage' => $storage, 'quota' => $limit));
+		return new \OC\Files\Storage\Wrapper\Quota(['storage' => $storage, 'quota' => $limit]);
 	}
 
 	public function testFilePutContentsNotEnoughSpace() {
@@ -70,7 +70,7 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 	public function testFreeSpaceWithUsedSpace() {
 		$instance = $this->getLimitedStorage(9);
 		$instance->getCache()->put(
-			'', array('size' => 3)
+			'', ['size' => 3]
 		);
 		$this->assertEquals(6, $instance->free_space(''));
 	}
@@ -85,9 +85,9 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 			->willReturn(-2);
 		$storage->getScanner()->scan('');
 
-		$instance = new \OC\Files\Storage\Wrapper\Quota(array('storage' => $storage, 'quota' => 9));
+		$instance = new \OC\Files\Storage\Wrapper\Quota(['storage' => $storage, 'quota' => 9]);
 		$instance->getCache()->put(
-			'', array('size' => 3)
+			'', ['size' => 3]
 		);
 		$this->assertEquals(6, $instance->free_space(''));
 	}
@@ -95,7 +95,7 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 	public function testFreeSpaceWithUsedSpaceAndEncryption() {
 		$instance = $this->getLimitedStorage(9);
 		$instance->getCache()->put(
-			'', array('size' => 7)
+			'', ['size' => 7]
 		);
 		$this->assertEquals(2, $instance->free_space(''));
 	}
@@ -140,7 +140,7 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 			->method('fopen')
 			->willReturn(false);
 
-		$instance = new \OC\Files\Storage\Wrapper\Quota(array('storage' => $failStorage, 'quota' => 1000));
+		$instance = new \OC\Files\Storage\Wrapper\Quota(['storage' => $failStorage, 'quota' => 1000]);
 
 		$this->assertFalse($instance->fopen('failedfopen', 'r'));
 	}
@@ -198,7 +198,7 @@ class QuotaTest extends \Test\Files\Storage\Storage {
 			->with('files')
 			->willReturn(new CacheEntry(['size' => 50]));
 
-		$instance = new \OC\Files\Storage\Wrapper\Quota(array('storage' => $storage, 'quota' => 1024, 'root' => 'files'));
+		$instance = new \OC\Files\Storage\Wrapper\Quota(['storage' => $storage, 'quota' => 1024, 'root' => 'files']);
 
 		$this->assertEquals(1024 - 50, $instance->free_space(''));
 	}
diff --git a/tests/lib/Files/Storage/Wrapper/WrapperTest.php b/tests/lib/Files/Storage/Wrapper/WrapperTest.php
index 2477b361bc1..b9bb54e09b2 100644
--- a/tests/lib/Files/Storage/Wrapper/WrapperTest.php
+++ b/tests/lib/Files/Storage/Wrapper/WrapperTest.php
@@ -18,8 +18,8 @@ class WrapperTest extends \Test\Files\Storage\Storage {
 		parent::setUp();
 
 		$this->tmpDir = \OC::$server->getTempManager()->getTemporaryFolder();
-		$storage = new \OC\Files\Storage\Local(array('datadir' => $this->tmpDir));
-		$this->instance = new \OC\Files\Storage\Wrapper\Wrapper(array('storage' => $storage));
+		$storage = new \OC\Files\Storage\Local(['datadir' => $this->tmpDir]);
+		$this->instance = new \OC\Files\Storage\Wrapper\Wrapper(['storage' => $storage]);
 	}
 
 	protected function tearDown(): void {