aboutsummaryrefslogtreecommitdiffstats
path: root/tests/lib
diff options
context:
space:
mode:
authorJoas Schilling <coding@schilljs.com>2023-07-05 10:19:45 +0200
committerJoas Schilling <coding@schilljs.com>2023-10-06 15:29:25 +0200
commitad839dbb0a095911da519ef19c6a8b494d0f1697 (patch)
tree3ef005001f7d8084ac573146efacf0b6a0bd4008 /tests/lib
parent00acf1bae1b35dcbd13e858ccc1a706f2c6e1d8c (diff)
downloadnextcloud-server-ad839dbb0a095911da519ef19c6a8b494d0f1697.tar.gz
nextcloud-server-ad839dbb0a095911da519ef19c6a8b494d0f1697.zip
fix(sqlite): Remove no longer required autoincrement fix
- I installed current master and exported the schema as SQL - Then I went to this branch, removed the content of the run() method (so made it no-op) - I installed again and exported the schema as SQL - The files are exactly the same, so whatever we tried to fix was fixed since 2015 in doctrine dbal Signed-off-by: Joas Schilling <coding@schilljs.com>
Diffstat (limited to 'tests/lib')
-rw-r--r--tests/lib/Repair/RepairSqliteAutoincrementTest.php90
1 files changed, 0 insertions, 90 deletions
diff --git a/tests/lib/Repair/RepairSqliteAutoincrementTest.php b/tests/lib/Repair/RepairSqliteAutoincrementTest.php
deleted file mode 100644
index b4be47d0157..00000000000
--- a/tests/lib/Repair/RepairSqliteAutoincrementTest.php
+++ /dev/null
@@ -1,90 +0,0 @@
-<?php
-/**
- * Copyright (c) 2015 Vincent Petry <pvince81@owncloud.com>
- * This file is licensed under the Affero General Public License version 3 or
- * later.
- * See the COPYING-README file.
- */
-
-namespace Test\Repair;
-
-use OC\DB\Connection;
-use OCP\Migration\IOutput;
-
-/**
- * Tests for fixing the SQLite id recycling
- *
- * @group DB
- */
-class RepairSqliteAutoincrementTest extends \Test\TestCase {
- /**
- * @var \OC\Repair\SqliteAutoincrement
- */
- private $repair;
-
- /**
- * @var Connection
- */
- private $connection;
-
- /**
- * @var string
- */
- private $tableName;
-
- /**
- * @var \OCP\IConfig
- */
- private $config;
-
- protected function setUp(): void {
- parent::setUp();
-
- $this->connection = \OC::$server->get(\OC\DB\Connection::class);
- $this->config = \OC::$server->getConfig();
- if (!$this->connection->getDatabasePlatform() instanceof \Doctrine\DBAL\Platforms\SqlitePlatform) {
- $this->markTestSkipped("Test only relevant on Sqlite");
- }
-
- $dbPrefix = $this->config->getSystemValueString('dbtableprefix', 'oc_');
- $this->tableName = $this->getUniqueID($dbPrefix . 'autoinc_test');
- $this->connection->prepare('CREATE TABLE ' . $this->tableName . '("someid" INTEGER NOT NULL, "text" VARCHAR(16), PRIMARY KEY("someid"))')->execute();
-
- $this->repair = new \OC\Repair\SqliteAutoincrement($this->connection);
- }
-
- protected function tearDown(): void {
- $this->connection->getSchemaManager()->dropTable($this->tableName);
- parent::tearDown();
- }
-
- /**
- * Tests whether autoincrement works
- *
- * @return boolean true if autoincrement works, false otherwise
- */
- protected function checkAutoincrement() {
- $this->connection->executeUpdate('INSERT INTO ' . $this->tableName . ' ("text") VALUES ("test")');
- $insertId = $this->connection->lastInsertId();
- $this->connection->executeUpdate('DELETE FROM ' . $this->tableName . ' WHERE "someid" = ?', [$insertId]);
-
- // insert again
- $this->connection->executeUpdate('INSERT INTO ' . $this->tableName . ' ("text") VALUES ("test2")');
- $newInsertId = $this->connection->lastInsertId();
-
- return ($insertId !== $newInsertId);
- }
-
- public function testConvertIdColumn() {
- $this->assertFalse($this->checkAutoincrement());
-
- /** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
- $outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->repair->run($outputMock);
-
- $this->assertTrue($this->checkAutoincrement());
- }
-}