Add tests for database user backend caching

Add comment, closeCursor in user DB query

Invalidate user in cache after successful creation

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

1 files changed, 18 insertions, 1 deletions

diff --git a/tests/lib/User/DatabaseTest.php b/tests/lib/User/DatabaseTest.php
index d7e4b9256cb..0e6900651cd 100644
--- a/tests/lib/User/DatabaseTest.php
+++ b/tests/lib/User/DatabaseTest.php
@@ -87,7 +87,7 @@ class DatabaseTest extends Backend {
 		$this->eventDispatcher->expects($this->once())->method('dispatch')
 			->willReturnCallback(
 				function ($eventName, GenericEvent $event) {
-					$this->assertSame('OCP\PasswordPolicy::validate',  $eventName);
+					$this->assertSame('OCP\PasswordPolicy::validate', $eventName);
 					$this->assertSame('newpass', $event->getSubject());
 					throw new HintException('password change failed', 'password change failed');
 				}
@@ -96,4 +96,21 @@ class DatabaseTest extends Backend {
 		$this->backend->setPassword($user, 'newpass');
 		$this->assertSame($user, $this->backend->checkPassword($user, 'newpass'));
 	}
+
+	public function testCreateUserInvalidatesCache() {
+		$user1 = $this->getUniqueID('test_');
+		$this->assertFalse($this->backend->userExists($user1));
+		$this->backend->createUser($user1, 'pw');
+		$this->assertTrue($this->backend->userExists($user1));
+	}
+
+	public function testDeleteUserInvalidatesCache() {
+		$user1 = $this->getUniqueID('test_');
+		$this->backend->createUser($user1, 'pw');
+		$this->assertTrue($this->backend->userExists($user1));
+		$this->backend->deleteUser($user1);
+		$this->assertFalse($this->backend->userExists($user1));
+		$this->backend->createUser($user1, 'pw2');
+		$this->assertTrue($this->backend->userExists($user1));
+	}
 }