diff options
author | Joas Schilling <213943+nickvergessen@users.noreply.github.com> | 2022-05-12 15:45:58 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-12 15:45:58 +0200 |
commit | 32139610c5e11ee84c71cc1db3e58523f749aa27 (patch) | |
tree | 015a97fa4209e186a6433650d3440bb5bdf7f89e /tests | |
parent | 33ffaad14bd15c8f6ed370b28bc83feec4f69980 (diff) | |
parent | 01dbd22c9c2347fffc28240e4a1bd9ccf509a24b (diff) | |
download | nextcloud-server-32139610c5e11ee84c71cc1db3e58523f749aa27.tar.gz nextcloud-server-32139610c5e11ee84c71cc1db3e58523f749aa27.zip |
Merge pull request #32355 from nextcloud/bugfix/noid/prevent-invalid-length
Validate requested length is random string generator
Diffstat (limited to 'tests')
-rw-r--r-- | tests/lib/Security/SecureRandomTest.php | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/tests/lib/Security/SecureRandomTest.php b/tests/lib/Security/SecureRandomTest.php index 7257d52e8f5..c7ee76a96bb 100644 --- a/tests/lib/Security/SecureRandomTest.php +++ b/tests/lib/Security/SecureRandomTest.php @@ -16,7 +16,6 @@ use OC\Security\SecureRandom; class SecureRandomTest extends \Test\TestCase { public function stringGenerationProvider() { return [ - [0, 0], [1, 1], [128, 128], [256, 256], @@ -77,4 +76,20 @@ class SecureRandomTest extends \Test\TestCase { $matchesRegex = preg_match('/^'.$chars.'+$/', $randomString); $this->assertSame(1, $matchesRegex); } + + public static function invalidLengths() { + return [ + [0], + [-1], + ]; + } + + /** + * @dataProvider invalidLengths + */ + public function testInvalidLengths($length) { + $this->expectException(\LengthException::class); + $generator = $this->rng; + $generator->generate($length); + } } |