aboutsummaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorblizzz <blizzz@arthur-schiwon.de>2023-03-02 12:10:19 +0100
committerGitHub <noreply@github.com>2023-03-02 12:10:19 +0100
commit289fadfd504f0a36836e8c0a082a51e16d3b8da2 (patch)
tree5bdf8c16668c83881e5c85037bb0481b8437c52f /tests
parente08fa782249c201baf042c8cdf2362fc2300f85f (diff)
parent1785a80754f57b9f98285a0b98e19af8f2afbdd6 (diff)
downloadnextcloud-server-289fadfd504f0a36836e8c0a082a51e16d3b8da2.tar.gz
nextcloud-server-289fadfd504f0a36836e8c0a082a51e16d3b8da2.zip
Merge pull request #36803 from nextcloud/fix/sqlite-comments
[db]: Remove not supported column comments for SQLite
Diffstat (limited to 'tests')
-rw-r--r--tests/lib/DB/MigratorTest.php24
1 files changed, 24 insertions, 0 deletions
diff --git a/tests/lib/DB/MigratorTest.php b/tests/lib/DB/MigratorTest.php
index af56730f9f6..6a2b113a796 100644
--- a/tests/lib/DB/MigratorTest.php
+++ b/tests/lib/DB/MigratorTest.php
@@ -237,6 +237,30 @@ class MigratorTest extends \Test\TestCase {
$this->addToAssertionCount(1);
}
+ /**
+ * Test for nextcloud/server#36803
+ */
+ public function testColumnCommentsInUpdate() {
+ $startSchema = new Schema([], [], $this->getSchemaConfig());
+ $table = $startSchema->createTable($this->tableName);
+ $table->addColumn('id', 'integer', ['autoincrement' => true, 'comment' => 'foo']);
+ $table->setPrimaryKey(['id']);
+
+ $endSchema = new Schema([], [], $this->getSchemaConfig());
+ $table = $endSchema->createTable($this->tableName);
+ $table->addColumn('id', 'integer', ['autoincrement' => true, 'comment' => 'foo']);
+ // Assert adding comments on existing tables work (or at least does not throw)
+ $table->addColumn('time', 'integer', ['comment' => 'unix-timestamp', 'notnull' => false]);
+ $table->setPrimaryKey(['id']);
+
+ $migrator = $this->getMigrator();
+ $migrator->migrate($startSchema);
+
+ $migrator->migrate($endSchema);
+
+ $this->addToAssertionCount(1);
+ }
+
public function testAddingForeignKey() {
$startSchema = new Schema([], [], $this->getSchemaConfig());
$table = $startSchema->createTable($this->tableName);