introduce SessionMiddleWare to control session handling via an annotation

1 files changed, 89 insertions, 0 deletions

diff --git a/tests/lib/appframework/middleware/sessionmiddlewaretest.php b/tests/lib/appframework/middleware/sessionmiddlewaretest.php
new file mode 100644
index 00000000000..13e558bf21a
--- /dev/null
+++ b/tests/lib/appframework/middleware/sessionmiddlewaretest.php
@@ -0,0 +1,89 @@
+<?php
+/**
+ * ownCloud - App Framework
+ *
+ * This file is licensed under the Affero General Public License version 3 or
+ * later. See the COPYING file.
+ *
+ * @author Thomas Müller <deepdiver@owncloud.com>
+ * @copyright Thomas Müller 2014
+ */
+
+
+namespace OC\AppFramework\Middleware\Security;
+
+use OC\AppFramework\Http\Request;
+use OC\AppFramework\Middleware\SessionMiddleware;
+use OC\AppFramework\Utility\ControllerMethodReflector;
+use OCP\AppFramework\Http\Response;
+
+
+class SessionMiddlewareTest extends \PHPUnit_Framework_TestCase {
+
+	/**
+	 * @var ControllerMethodReflector
+	 */
+	private $reflector;
+
+	/**
+	 * @var Request
+	 */
+	private $request;
+
+	protected function setUp() {
+		$this->request = new Request();
+		$this->reflector = new ControllerMethodReflector();
+	}
+
+	/**
+	 * @UseSession
+	 */
+	public function testSessionNotClosedOnBeforeController() {
+		$session = $this->getSessionMock(0);
+
+		$this->reflector->reflect($this, __FUNCTION__);
+		$middleware = new SessionMiddleware($this->request, $this->reflector, $session);
+		$middleware->beforeController($this, __FUNCTION__);
+	}
+
+	/**
+	 * @UseSession
+	 */
+	public function testSessionClosedOnAfterController() {
+		$session = $this->getSessionMock(1);
+
+		$this->reflector->reflect($this, __FUNCTION__);
+		$middleware = new SessionMiddleware($this->request, $this->reflector, $session);
+		$middleware->afterController($this, __FUNCTION__, new Response());
+	}
+
+	public function testSessionClosedOnBeforeController() {
+		$session = $this->getSessionMock(1);
+
+		$this->reflector->reflect($this, __FUNCTION__);
+		$middleware = new SessionMiddleware($this->request, $this->reflector, $session);
+		$middleware->beforeController($this, __FUNCTION__);
+	}
+
+	public function testSessionNotClosedOnAfterController() {
+		$session = $this->getSessionMock(0);
+
+		$this->reflector->reflect($this, __FUNCTION__);
+		$middleware = new SessionMiddleware($this->request, $this->reflector, $session);
+		$middleware->afterController($this, __FUNCTION__, new Response());
+	}
+
+	/**
+	 * @return mixed
+	 */
+	private function getSessionMock($expectedCloseCount) {
+		$session = $this->getMockBuilder('\OC\Session\Memory')
+			->disableOriginalConstructor()
+			->getMock();
+
+		$session->expects($this->exactly($expectedCloseCount))
+			->method('close');
+		return $session;
+	}
+
+}