diff options
| author | Vincent Petry <pvince81@owncloud.com> | 2016-06-23 15:43:21 +0200 |
|---|---|---|
| committer | Vincent Petry <pvince81@owncloud.com> | 2016-06-24 09:48:48 +0200 |
| commit | 955635c7aaaf932c698069a08ff8f218f0ea990c (patch) | |
| tree | 3c7d63791490f9311044c7370f234388baba9fff /tests | |
| parent | dc78d26f2abec23e68b5dd3011f698d7b9f6e6a3 (diff) | |
| download | nextcloud-server-955635c7aaaf932c698069a08ff8f218f0ea990c.tar.gz nextcloud-server-955635c7aaaf932c698069a08ff8f218f0ea990c.zip | |
Add explicit delete permission to link shares
Link shares always allowed deletion, however internally the permissions
were stored as 7 which lacked delete permissions. This created an
inconsistency in the Webdav permissions.
This fix makes sure we include delete permissions in the share
permissions, which now become 15.
In case a client is still passing 7 for legacy reasons, it gets
converted automatically to 15.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/lib/Share20/ManagerTest.php | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/tests/lib/Share20/ManagerTest.php b/tests/lib/Share20/ManagerTest.php index a50ea6c892a..d2539f8577c 100644 --- a/tests/lib/Share20/ManagerTest.php +++ b/tests/lib/Share20/ManagerTest.php @@ -1320,24 +1320,6 @@ class ManagerTest extends \Test\TestCase { /** * @expectedException Exception - * @expectedExceptionMessage Link shares can't have delete permissions - */ - public function testLinkCreateChecksDeletePermissions() { - $share = $this->manager->newShare(); - - $share->setPermissions(\OCP\Constants::PERMISSION_DELETE); - - $this->config - ->method('getAppValue') - ->will($this->returnValueMap([ - ['core', 'shareapi_allow_links', 'yes', 'yes'], - ])); - - $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]); - } - - /** - * @expectedException Exception * @expectedExceptionMessage Public upload not allowed */ public function testLinkCreateChecksNoPublicUpload() { |