Add navigation via info.xml (#26785)

* Read navigation information from info.xml

* Load files navigation elements from info.xml

* Add comment about ignoring the exception

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

1 files changed, 64 insertions, 0 deletions

diff --git a/tests/lib/NavigationManagerTest.php b/tests/lib/NavigationManagerTest.php
index 96708786e39..942dcbe1865 100644
--- a/tests/lib/NavigationManagerTest.php
+++ b/tests/lib/NavigationManagerTest.php
@@ -13,6 +13,13 @@
 namespace Test;
 
 use OC\NavigationManager;
+use OCP\App\IAppManager;
+use OCP\IGroupManager;
+use OCP\IL10N;
+use OCP\IURLGenerator;
+use OCP\IUser;
+use OCP\IUserSession;
+use OCP\L10N\IFactory;
 
 class NavigationManagerTest extends TestCase {
 	/** @var \OC\NavigationManager */
@@ -157,4 +164,61 @@ class NavigationManagerTest extends TestCase {
 		$this->assertEmpty($this->navigationManager->getAll(), 'Expected no navigation entry exists after clear()');
 		$this->assertEquals(0, $testAddClosureNumberOfCalls, 'Expected that the closure is not called by getAll()');
 	}
+
+	/**
+	 * @dataProvider providesNavigationConfig
+	 */
+	public function testWithAppManager($expected, $config, $isAdmin = false) {
+
+		$appManager = $this->createMock(IAppManager::class);
+		$urlGenerator = $this->createMock(IURLGenerator::class);
+		$l10nFac = $this->createMock(IFactory::class);
+		$userSession = $this->createMock(IUserSession::class);
+		$groupManager = $this->createMock(IGroupManager::class);
+		$l = $this->createMock(IL10N::class);
+		$l->expects($this->any())->method('t')->willReturnCallback(function($text, $parameters = []) {
+			return vsprintf($text, $parameters);
+		});
+
+		$appManager->expects($this->once())->method('getInstalledApps')->willReturn(['test']);
+		$appManager->expects($this->once())->method('getAppInfo')->with('test')->willReturn($config);
+		$l10nFac->expects($this->exactly(count($expected)))->method('get')->with('test')->willReturn($l);
+		$urlGenerator->expects($this->any())->method('imagePath')->willReturnCallback(function($appName, $file) {
+			return "/apps/$appName/img/$file";
+		});
+		$urlGenerator->expects($this->exactly(count($expected)))->method('linkToRoute')->willReturnCallback(function($route) {
+			return "/apps/test/";
+		});
+		$user = $this->createMock(IUser::class);
+		$user->expects($this->any())->method('getUID')->willReturn('user001');
+		$userSession->expects($this->any())->method('getUser')->willReturn($user);
+		$groupManager->expects($this->any())->method('isAdmin')->willReturn($isAdmin);
+
+		$navigationManager = new NavigationManager($appManager, $urlGenerator, $l10nFac, $userSession, $groupManager);
+
+		$entries = $navigationManager->getAll();
+		$this->assertEquals($expected, $entries);
+	}
+
+	public function providesNavigationConfig() {
+		return [
+			'minimalistic' => [[[
+				'id' => 'test',
+				'order' => 100,
+				'href' => '/apps/test/',
+				'icon' => '/apps/test/img/app.svg',
+				'name' => 'Test',
+				'active' => false
+			]], ['navigation' => ['route' => 'test.page.index']]],
+			'no admin' => [[[
+				'id' => 'test',
+				'order' => 100,
+				'href' => '/apps/test/',
+				'icon' => '/apps/test/img/app.svg',
+				'name' => 'Test',
+				'active' => false
+			]], ['navigation' => ['@attributes' => ['role' => 'admin'], 'route' => 'test.page.index']], true],
+			'admin' => [[], ['navigation' => ['@attributes' => ['role' => 'admin'], 'route' => 'test.page.index']]]
+		];
+	}
 }