summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorJohn Molakvoæ <skjnldsv@users.noreply.github.com>2018-06-11 09:30:18 +0200
committerGitHub <noreply@github.com>2018-06-11 09:30:18 +0200
commit142505ecb23c1d0864e0a479f1bdd59a8ec75324 (patch)
treee6c378d208b06c032e93a1fcc6a69045d6b1a9d7 /tests
parenta1496d7cc1d9f7b29062621deddd239cc37a9194 (diff)
parentb61e72fe00bcfef6d3e3ac39a8cf03ed0d3b9748 (diff)
downloadnextcloud-server-142505ecb23c1d0864e0a479f1bdd59a8ec75324.tar.gz
nextcloud-server-142505ecb23c1d0864e0a479f1bdd59a8ec75324.zip
Merge pull request #9810 from nextcloud/tests/9769/apps-management-acceptance
Acceptance tests for apps management and minor fixes
Diffstat (limited to 'tests')
-rw-r--r--tests/acceptance/config/behat.yml1
-rw-r--r--tests/acceptance/features/apps.feature90
-rw-r--r--tests/acceptance/features/bootstrap/AppsManagementContext.php232
-rw-r--r--tests/acceptance/features/bootstrap/SettingsMenuContext.php16
-rwxr-xr-xtests/acceptance/run.sh2
5 files changed, 340 insertions, 1 deletions
diff --git a/tests/acceptance/config/behat.yml b/tests/acceptance/config/behat.yml
index 965d5f02fcc..55d2ff3a6f4 100644
--- a/tests/acceptance/config/behat.yml
+++ b/tests/acceptance/config/behat.yml
@@ -9,6 +9,7 @@ default:
- AppNavigationContext
- AppSettingsContext
+ - AppsManagementContext
- CommentsAppContext
- ContactsMenuContext
- DialogContext
diff --git a/tests/acceptance/features/apps.feature b/tests/acceptance/features/apps.feature
new file mode 100644
index 00000000000..4881dfe9d8c
--- /dev/null
+++ b/tests/acceptance/features/apps.feature
@@ -0,0 +1,90 @@
+Feature: apps
+
+ Scenario: enable an installed app
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ When I enable the "QA testing" app
+ Then I see that the "QA testing" app has been enabled
+
+ Scenario: disable a installed app
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ When I disable the "Update notification" app
+ Then I see that the "Update notification" app has been disabled
+
+ Scenario: Browse enabled apps
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ When I open the "Active apps" section
+ Then I see that the current section is "Active apps"
+ And I see that there are only enabled apps
+
+ Scenario: Browse disabled apps
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ When I open the "Disabled apps" section
+ Then I see that the current section is "Disabled apps"
+ And I see that there are only disabled apps
+
+ Scenario: Browse app bundles
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ When I open the "App bundles" section
+ Then I see that the current section is "App bundles"
+ And I see the app bundles
+ And I see that the "Enterprise bundle" is disabled
+
+ Scenario: Enable an app bundle
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ And I open the "App bundles" section
+ When I enable all apps from the "Enterprise bundle"
+ Then I see that the "Auditing / Logging" app has been enabled
+ And I see that the "LDAP user and group backend" app has been enabled
+
+ Scenario: View app details
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ When I click on the "QA testing" app
+ Then I see that the app details are shown
+
+ # TODO: Improve testing with app store as external API
+ # The following scenarios require the files_antivirus and calendar app
+ # being present in the app store with support for the current server version
+ # Ideally we would have either a dummy app store endpoint with some test apps
+ # or even an app store instance running somewhere to properly test this.
+ # This is also a requirement to properly test updates of apps
+
+ Scenario: Show section from app store
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ And I see that the current section is "Your apps"
+ When I open the "Files" section
+ Then I see that there some apps listed from the app store
+ And I see that the current section is "Files"
+
+ Scenario: View app details for app store apps
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ And I open the "Tools" section
+ When I click on the "Antivirus App for files" app
+ Then I see that the app details are shown
+
+ Scenario: Install an app from the app store
+ Given I act as Jane
+ And I am logged in as the admin
+ And I open the Apps management
+ And I open the "Office & text" section
+ And I click on the "Calendar" app
+ And I see that the app details are shown
+ Then I download and enable the "Calendar" app
+ And I see that the "Calendar" app has been enabled
diff --git a/tests/acceptance/features/bootstrap/AppsManagementContext.php b/tests/acceptance/features/bootstrap/AppsManagementContext.php
new file mode 100644
index 00000000000..b9896305182
--- /dev/null
+++ b/tests/acceptance/features/bootstrap/AppsManagementContext.php
@@ -0,0 +1,232 @@
+<?php
+
+/**
+ *
+ * @copyright Copyright (c) 2018 Julius Härtl <jus@bitgrid.net>
+ *
+ * @author Julius Härtl <jus@bitgrid.net>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+use Behat\Behat\Context\Context;
+
+class AppsManagementContext implements Context, ActorAwareInterface {
+
+ use ActorAware;
+
+ /**
+ * @return Locator
+ */
+ public static function enableButtonForApp($app) {
+ return Locator::forThe()->button("Enable")->
+ descendantOf(self::rowForApp($app))->
+ describedAs("Enable button in the app list for $app");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function downloadAndEnableButtonForApp($app) {
+ return Locator::forThe()->button("Download and enable")->
+ descendantOf(self::rowForApp($app))->
+ describedAs("Download & enable button in the app list for $app");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function disableButtonForApp($app) {
+ return Locator::forThe()->button("Disable")->
+ descendantOf(self::rowForApp($app))->
+ describedAs("Disable button in the app list for $app");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function bundleButton($bundle) {
+ return Locator::forThe()->xpath("//div[@id='app-content']//div[@class='apps-header']/h2[normalize-space() = '$bundle']/input")->
+ describedAs("Button to enable / disable bundles");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function rowForApp($app) {
+ return Locator::forThe()->xpath("//div[@id='app-content']//div[@class='app-name'][normalize-space() = '$app']/..")->
+ describedAs("Row for app $app in Apps Management");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function emptyAppList() {
+ return Locator::forThe()->xpath("//div[@id='app-content']//div[@id='apps-list-empty']")->
+ describedAs("Empty apps list view");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function appEntries() {
+ return Locator::forThe()->xpath("//div[@id='app-content']//div[@class='section']")->
+ describedAs("Entries in apps list");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function disabledAppEntries() {
+ return Locator::forThe()->button("Disable")->
+ descendantOf(self::appEntries())->
+ describedAs("Disable button in the app list");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function enabledAppEntries() {
+ return Locator::forThe()->button("Enable")->
+ descendantOf(self::appEntries())->
+ describedAs("Enable button in the app list");
+ }
+
+ /**
+ * @return Locator
+ */
+ public static function sidebar() {
+ return Locator::forThe()->id("app-sidebar")->
+ describedAs("Sidebar in apps management");
+ }
+
+
+ /**
+ * @When I enable the :app app
+ */
+ public function iEnableTheApp($app) {
+ $this->actor->find(self::enableButtonForApp($app), 10)->click();
+ }
+
+ /**
+ * @When I download and enable the :app app
+ */
+ public function iDownloadAndEnableTheApp($app) {
+ $this->actor->find(self::downloadAndEnableButtonForApp($app), 10)->click();
+ }
+
+ /**
+ * @When I disable the :app app
+ */
+ public function iDisableTheApp($app) {
+ $this->actor->find(self::disableButtonForApp($app), 10)->click();
+ }
+
+ /**
+ * @Then I see that the :app app has been enabled
+ */
+ public function iSeeThatTheAppHasBeenEnabled($app) {
+ // TODO: Find a way to check if the enable button is removed
+ $this->actor->find(self::disableButtonForApp($app), 10);
+ }
+
+ /**
+ * @Then I see that the :app app has been disabled
+ */
+ public function iSeeThatTheAppHasBeenDisabled($app) {
+ // TODO: Find a way to check if the disable button is removed
+ $this->actor->find(self::enableButtonForApp($app), 10);
+ }
+
+ /**
+ * @Then /^I see that there are no available updates$/
+ */
+ public function iSeeThatThereAreNoAvailableUpdates() {
+ PHPUnit_Framework_Assert::assertTrue(
+ $this->actor->find(self::emptyAppList(), 10)->isVisible()
+ );
+ }
+
+ /**
+ * @Then /^I see that there some apps listed from the app store$/
+ */
+ public function iSeeThatThereSomeAppsListedFromTheAppStore() {
+ WaitFor::elementToBeEventuallyShown($this->actor, self::appEntries(), 10);
+ }
+
+ /**
+ * @When /^I click on the "([^"]*)" app$/
+ */
+ public function iClickOnTheApp($app) {
+ $this->actor->find(self::rowForApp($app), 10)->click();
+ }
+
+ /**
+ * @Given /^I see that there are only disabled apps$/
+ */
+ public function iSeeThatThereAreOnlyDisabledApps() {
+ $buttons = $this->actor->getSession()->getDriver()->find("//input[@value = 'Disable']");
+ PHPUnit\Framework\Assert::assertEmpty($buttons, 'Found disabled apps');
+ }
+
+ /**
+ * @Given /^I see that there are only enabled apps$/
+ */
+ public function iSeeThatThereAreOnlyEnabledApps() {
+ $buttons = $this->actor->getSession()->getDriver()->find("//input[@value = 'Enable']");
+ PHPUnit\Framework\Assert::assertEmpty($buttons, 'Found disabled apps');
+ }
+
+ /**
+ * @Given /^I see the app bundles$/
+ */
+ public function iSeeTheAppBundles() {
+ $this->actor->find(self::rowForApp('Auditing / Logging'), 2);
+ $this->actor->find(self::rowForApp('LDAP user and group backend'), 2);
+ }
+
+ /**
+ * @When /^I enable all apps from the "([^"]*)"$/
+ */
+ public function iEnableAllAppsFromThe($bundle) {
+ $this->actor->find(self::bundleButton($bundle), 2)->click();
+ }
+
+ /**
+ * @Given /^I see that the "([^"]*)" is disabled$/
+ */
+ public function iSeeThatTheIsDisabled($bundle) {
+ PHPUnit\Framework\Assert::assertEquals('Enable all', $this->actor->find(self::bundleButton($bundle))->getValue());
+ }
+
+ /**
+ * @Given /^I see that the app details are shown$/
+ */
+ public function iSeeThatTheAppDetailsAreShown() {
+ // The sidebar always exists in the DOM, so it has to be explicitly
+ // waited for it to be visible instead of relying on the implicit wait
+ // made to find the element.
+ if (!WaitFor::elementToBeEventuallyShown(
+ $this->actor,
+ self::sidebar(),
+ $timeout = 10 * $this->actor->getFindTimeoutMultiplier())) {
+ PHPUnit_Framework_Assert::fail("The sidebar was not shown yet after $timeout seconds");
+ }
+ }
+
+
+}
diff --git a/tests/acceptance/features/bootstrap/SettingsMenuContext.php b/tests/acceptance/features/bootstrap/SettingsMenuContext.php
index eddf2599d78..6187d9f6c10 100644
--- a/tests/acceptance/features/bootstrap/SettingsMenuContext.php
+++ b/tests/acceptance/features/bootstrap/SettingsMenuContext.php
@@ -54,6 +54,13 @@ class SettingsMenuContext implements Context, ActorAwareInterface {
/**
* @return Locator
*/
+ public static function usersAppsItem() {
+ return self::menuItemFor("Apps");
+ }
+
+ /**
+ * @return Locator
+ */
public static function logOutMenuItem() {
return self::menuItemFor("Log out");
}
@@ -101,6 +108,15 @@ class SettingsMenuContext implements Context, ActorAwareInterface {
}
/**
+ * @When I open the Apps management
+ */
+ public function iOpenTheAppsManagement() {
+ $this->iOpenTheSettingsMenu();
+
+ $this->actor->find(self::usersAppsItem(), 2)->click();
+ }
+
+ /**
* @When I visit the settings page
*/
public function iVisitTheSettingsPage() {
diff --git a/tests/acceptance/run.sh b/tests/acceptance/run.sh
index f2bc66048d7..3ed1207e379 100755
--- a/tests/acceptance/run.sh
+++ b/tests/acceptance/run.sh
@@ -147,7 +147,7 @@ function prepareDocker() {
# "docker cp" does not take them into account (the extracted files are set
# to root).
echo "Copying local Git working directory of Nextcloud to the container"
- tar --create --file="$NEXTCLOUD_LOCAL_TAR" --exclude=".git" --exclude="./build" --exclude="./config/config.php" --exclude="./data" --exclude="./data-autotest" --exclude="./tests" --directory=../../ .
+ tar --create --file="$NEXTCLOUD_LOCAL_TAR" --exclude=".git" --exclude="./build" --exclude="./config/config.php" --exclude="./data" --exclude="./data-autotest" --exclude="./tests" --exclude="./apps-extra" --exclude="apps-writable" --directory=../../ .
tar --append --file="$NEXTCLOUD_LOCAL_TAR" --directory=../../ tests/acceptance/
docker exec $NEXTCLOUD_LOCAL_CONTAINER mkdir /nextcloud