diff options
author | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2017-07-08 15:36:01 +0200 |
---|---|---|
committer | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2017-07-08 15:36:01 +0200 |
commit | 71b90cdeff2e8e8c71a315aadf615da2bd1e63a7 (patch) | |
tree | f552887ce2b1715a7ef0d0601da087b27f4e5119 /tests | |
parent | 8deab238cc2aacaadcacc5ab918255a33b85fc87 (diff) | |
download | nextcloud-server-71b90cdeff2e8e8c71a315aadf615da2bd1e63a7.tar.gz nextcloud-server-71b90cdeff2e8e8c71a315aadf615da2bd1e63a7.zip |
Extract app navigation elements to its own context
The app navigation is not exclusive to the Files app but a generic
component used by other apps too, so its locators and steps should be in
its own context.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/acceptance/config/behat.yml | 1 | ||||
-rw-r--r-- | tests/acceptance/features/bootstrap/AppNavigationContext.php | 69 | ||||
-rw-r--r-- | tests/acceptance/features/bootstrap/FilesAppContext.php | 39 |
3 files changed, 70 insertions, 39 deletions
diff --git a/tests/acceptance/config/behat.yml b/tests/acceptance/config/behat.yml index 15310e6883f..86510083761 100644 --- a/tests/acceptance/config/behat.yml +++ b/tests/acceptance/config/behat.yml @@ -9,6 +9,7 @@ default: - ActorContext - NextcloudTestServerContext + - AppNavigationContext - FeatureContext - FilesAppContext - FilesSharingAppContext diff --git a/tests/acceptance/features/bootstrap/AppNavigationContext.php b/tests/acceptance/features/bootstrap/AppNavigationContext.php new file mode 100644 index 00000000000..9ef71a06065 --- /dev/null +++ b/tests/acceptance/features/bootstrap/AppNavigationContext.php @@ -0,0 +1,69 @@ +<?php + +/** + * + * @copyright Copyright (c) 2017, Daniel Calviño Sánchez (danxuliu@gmail.com) + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +use Behat\Behat\Context\Context; + +class AppNavigationContext implements Context, ActorAwareInterface { + + use ActorAware; + + /** + * @return Locator + */ + public static function appNavigation() { + return Locator::forThe()->id("app-navigation")-> + describedAs("App navigation"); + } + + /** + * @return Locator + */ + public static function appNavigationSectionItemFor($sectionText) { + return Locator::forThe()->xpath("//li[normalize-space() = '$sectionText']")-> + descendantOf(self::appNavigation())-> + describedAs($sectionText . " section item in App Navigation"); + } + + /** + * @return Locator + */ + public static function appNavigationCurrentSectionItem() { + return Locator::forThe()->css(".active")->descendantOf(self::appNavigation())-> + describedAs("Current section item in App Navigation"); + } + + /** + * @Given I open the :section section + */ + public function iOpenTheSection($section) { + $this->actor->find(self::appNavigationSectionItemFor($section), 10)->click(); + } + + /** + * @Then I see that the current section is :section + */ + public function iSeeThatTheCurrentSectionIs($section) { + PHPUnit_Framework_Assert::assertEquals($this->actor->find(self::appNavigationCurrentSectionItem(), 10)->getText(), $section); + } + +} diff --git a/tests/acceptance/features/bootstrap/FilesAppContext.php b/tests/acceptance/features/bootstrap/FilesAppContext.php index 135d603c2a6..782972033fd 100644 --- a/tests/acceptance/features/bootstrap/FilesAppContext.php +++ b/tests/acceptance/features/bootstrap/FilesAppContext.php @@ -44,31 +44,6 @@ class FilesAppContext implements Context, ActorAwareInterface { /** * @return Locator */ - public static function appNavigation() { - return Locator::forThe()->id("app-navigation")-> - describedAs("App navigation"); - } - - /** - * @return Locator - */ - public static function appNavigationSectionItemFor($sectionText) { - return Locator::forThe()->xpath("//li[normalize-space() = '$sectionText']")-> - descendantOf(self::appNavigation())-> - describedAs($sectionText . " section item in App Navigation"); - } - - /** - * @return Locator - */ - public static function appNavigationCurrentSectionItem() { - return Locator::forThe()->css(".active")->descendantOf(self::appNavigation())-> - describedAs("Current section item in App Navigation"); - } - - /** - * @return Locator - */ public static function mainViewForSection($section) { $sectionId = self::sections()[$section]; @@ -355,13 +330,6 @@ class FilesAppContext implements Context, ActorAwareInterface { } /** - * @Given I open the :section section - */ - public function iOpenTheSection($section) { - $this->actor->find(self::appNavigationSectionItemFor($section), 10)->click(); - } - - /** * @Given I open the details view for :fileName */ public function iOpenTheDetailsViewFor($fileName) { @@ -446,13 +414,6 @@ class FilesAppContext implements Context, ActorAwareInterface { } /** - * @Then I see that the current section is :section - */ - public function iSeeThatTheCurrentSectionIs($section) { - PHPUnit_Framework_Assert::assertEquals($this->actor->find(self::appNavigationCurrentSectionItem(), 10)->getText(), $section); - } - - /** * @Then I see that the details view for :section section is open */ public function iSeeThatTheDetailsViewForSectionIsOpen($section) { |