diff options
author | Julius Härtl <jus@bitgrid.net> | 2019-04-18 11:39:49 +0200 |
---|---|---|
committer | Julius Härtl <jus@bitgrid.net> | 2019-04-18 11:39:49 +0200 |
commit | db17c14f8039cef674f4c07f5dff05c105b39c49 (patch) | |
tree | 794c73eddb21c4fb56da37b138ac2a4c6ca9ad9c /tests | |
parent | 16b8017fc906f7a3cf105304f6abdc0e2443a078 (diff) | |
download | nextcloud-server-db17c14f8039cef674f4c07f5dff05c105b39c49.tar.gz nextcloud-server-db17c14f8039cef674f4c07f5dff05c105b39c49.zip |
Respect sharing enumeration config in contacts menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/lib/Contacts/ContactsMenu/ManagerTest.php | 81 |
1 files changed, 80 insertions, 1 deletions
diff --git a/tests/lib/Contacts/ContactsMenu/ManagerTest.php b/tests/lib/Contacts/ContactsMenu/ManagerTest.php index 783e5590a29..d1630e8ddeb 100644 --- a/tests/lib/Contacts/ContactsMenu/ManagerTest.php +++ b/tests/lib/Contacts/ContactsMenu/ManagerTest.php @@ -30,6 +30,7 @@ use OC\Contacts\ContactsMenu\Manager; use OCP\App\IAppManager; use OCP\Contacts\ContactsMenu\IEntry; use OCP\Contacts\ContactsMenu\IProvider; +use OCP\IConfig; use OCP\IUser; use PHPUnit_Framework_MockObject_MockObject; use Test\TestCase; @@ -42,6 +43,9 @@ class ManagerTest extends TestCase { /** @var IAppManager|PHPUnit_Framework_MockObject_MockObject */ private $appManager; + /** @var IConfig|PHPUnit_Framework_MockObject_MockObject */ + private $config; + /** @var ActionProviderStore|PHPUnit_Framework_MockObject_MockObject */ private $actionProviderStore; @@ -54,8 +58,9 @@ class ManagerTest extends TestCase { $this->contactsStore = $this->createMock(ContactsStore::class); $this->actionProviderStore = $this->createMock(ActionProviderStore::class); $this->appManager = $this->createMock(IAppManager::class); + $this->config = $this->createMock(IConfig::class); - $this->manager = new Manager($this->contactsStore, $this->actionProviderStore, $this->appManager); + $this->manager = new Manager($this->contactsStore, $this->actionProviderStore, $this->appManager, $this->config); } private function generateTestEntries() { @@ -75,6 +80,15 @@ class ManagerTest extends TestCase { $user = $this->createMock(IUser::class); $entries = $this->generateTestEntries(); $provider = $this->createMock(IProvider::class); + + $this->config->expects($this->at(0)) + ->method('getSystemValueInt') + ->with('sharing.maxAutocompleteResults', 25) + ->willReturn(25); + $this->config->expects($this->at(1)) + ->method('getSystemValueInt') + ->with('sharing.minSearchStringLength', 0) + ->willReturn(0); $this->contactsStore->expects($this->once()) ->method('getContacts') ->with($user, $filter) @@ -99,6 +113,71 @@ class ManagerTest extends TestCase { $this->assertEquals($expected, $data); } + public function testGetFilteredEntriesLimit() { + $filter = 'con'; + $user = $this->createMock(IUser::class); + $entries = $this->generateTestEntries(); + $provider = $this->createMock(IProvider::class); + + $this->config->expects($this->at(0)) + ->method('getSystemValueInt') + ->with('sharing.maxAutocompleteResults', 25) + ->willReturn(3); + $this->config->expects($this->at(1)) + ->method('getSystemValueInt') + ->with('sharing.minSearchStringLength', 0) + ->willReturn(0); + $this->contactsStore->expects($this->once()) + ->method('getContacts') + ->with($user, $filter) + ->willReturn($entries); + $this->actionProviderStore->expects($this->once()) + ->method('getProviders') + ->with($user) + ->willReturn([$provider]); + $provider->expects($this->exactly(3)) + ->method('process'); + $this->appManager->expects($this->once()) + ->method('isEnabledForUser') + ->with($this->equalTo('contacts'), $user) + ->willReturn(false); + $expected = [ + 'contacts' => array_slice($entries, 0, 3), + 'contactsAppEnabled' => false, + ]; + + $data = $this->manager->getEntries($user, $filter); + + $this->assertEquals($expected, $data); + } + + public function testGetFilteredEntriesMinSearchStringLength() { + $filter = 'con'; + $user = $this->createMock(IUser::class); + $provider = $this->createMock(IProvider::class); + + $this->config->expects($this->at(0)) + ->method('getSystemValueInt') + ->with('sharing.maxAutocompleteResults', 25) + ->willReturn(3); + $this->config->expects($this->at(1)) + ->method('getSystemValueInt') + ->with('sharing.minSearchStringLength', 0) + ->willReturn(4); + $this->appManager->expects($this->once()) + ->method('isEnabledForUser') + ->with($this->equalTo('contacts'), $user) + ->willReturn(false); + $expected = [ + 'contacts' => [], + 'contactsAppEnabled' => false, + ]; + + $data = $this->manager->getEntries($user, $filter); + + $this->assertEquals($expected, $data); + } + public function testFindOne() { $shareTypeFilter = 42; $shareWithFilter = 'foobar'; |