Add check for activated local memcache

Also used the opportunity to refactor it into an AppFramework controller so that we can unit test it.

Fixes https://github.com/owncloud/core/issues/14956

2 files changed, 231 insertions, 8 deletions

diff --git a/tests/lib/util.php b/tests/lib/util.php
index 7d9064e0a2f..49399c8cf01 100644
--- a/tests/lib/util.php
+++ b/tests/lib/util.php
@@ -129,14 +129,6 @@ class Test_Util extends \Test\TestCase {
 		$this->assertEquals($expected, \OC_Util::fileInfoLoaded());
 	}
 
-	public function testIsInternetConnectionEnabled() {
-		\OC_Config::setValue("has_internet_connection", false);
-		$this->assertFalse(\OC_Util::isInternetConnectionEnabled());
-
-		\OC_Config::setValue("has_internet_connection", true);
-		$this->assertTrue(\OC_Util::isInternetConnectionEnabled());
-	}
-
 	function testGenerateRandomBytes() {
 		$result = strlen(OC_Util::generateRandomBytes(59));
 		$this->assertEquals(59, $result);
diff --git a/tests/settings/controller/CheckSetupControllerTest.php b/tests/settings/controller/CheckSetupControllerTest.php
new file mode 100644
index 00000000000..fc17d2adc49
--- /dev/null
+++ b/tests/settings/controller/CheckSetupControllerTest.php
@@ -0,0 +1,231 @@
+<?php
+/**
+ * @author Lukas Reschke <lukas@owncloud.com>
+ *
+ * @copyright Copyright (c) 2015, ownCloud, Inc.
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+namespace OC\Settings\Controller;
+
+use OCP\AppFramework\Http\DataResponse;
+use Test\TestCase;
+use OCP\IRequest;
+use OCP\IConfig;
+use OCP\Http\Client\IClientService;
+use OC_Util;
+
+/**
+ * Class CheckSetupControllerTest
+ *
+ * @package OC\Settings\Controller
+ */
+class CheckSetupControllerTest extends TestCase {
+	/** @var CheckSetupController */
+	private $checkSetupController;
+	/** @var IRequest */
+	private $request;
+	/** @var IConfig */
+	private $config;
+	/** @var IClientService */
+	private $clientService;
+	/** @var OC_Util */
+	private $util;
+
+	public function setUp() {
+		parent::setUp();
+
+		$this->request = $this->getMockBuilder('\OCP\IRequest')
+			->disableOriginalConstructor()->getMock();
+		$this->config = $this->getMockBuilder('\OCP\IConfig')
+			->disableOriginalConstructor()->getMock();
+		$this->config = $this->getMockBuilder('\OCP\IConfig')
+			->disableOriginalConstructor()->getMock();
+		$this->clientService = $this->getMockBuilder('\OCP\Http\Client\IClientService')
+			->disableOriginalConstructor()->getMock();
+		$this->util = $this->getMockBuilder('\OC_Util')
+			->disableOriginalConstructor()->getMock();
+
+		$this->checkSetupController = new CheckSetupController(
+			'settings',
+			$this->request,
+			$this->config,
+			$this->clientService,
+			$this->util
+		);
+	}
+
+	public function testIsInternetConnectionWorkingDisabledViaConfig() {
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('has_internet_connection', true)
+			->will($this->returnValue(false));
+
+		$this->assertFalse(
+			\Test_Helper::invokePrivate(
+				$this->checkSetupController,
+				'isInternetConnectionWorking'
+			)
+		);
+	}
+
+	public function testIsInternetConnectionWorkingCorrectly() {
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('has_internet_connection', true)
+			->will($this->returnValue(true));
+
+		$client = $this->getMockBuilder('\OCP\Http\Client\IClient')
+			->disableOriginalConstructor()->getMock();
+		$client->expects($this->at(0))
+			->method('get')
+			->with('https://www.owncloud.org/', []);
+		$client->expects($this->at(1))
+			->method('get')
+			->with('http://www.owncloud.org/', []);
+
+		$this->clientService->expects($this->once())
+			->method('newClient')
+			->will($this->returnValue($client));
+
+
+		$this->assertTrue(
+			\Test_Helper::invokePrivate(
+				$this->checkSetupController,
+				'isInternetConnectionWorking'
+			)
+		);
+	}
+
+	public function testIsInternetConnectionHttpsFail() {
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('has_internet_connection', true)
+			->will($this->returnValue(true));
+
+		$client = $this->getMockBuilder('\OCP\Http\Client\IClient')
+			->disableOriginalConstructor()->getMock();
+		$client->expects($this->at(0))
+			->method('get')
+			->with('https://www.owncloud.org/', [])
+			->will($this->throwException(new \Exception()));
+
+		$this->clientService->expects($this->once())
+			->method('newClient')
+			->will($this->returnValue($client));
+
+		$this->assertFalse(
+			\Test_Helper::invokePrivate(
+				$this->checkSetupController,
+				'isInternetConnectionWorking'
+			)
+		);
+	}
+
+	public function testIsInternetConnectionHttpFail() {
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('has_internet_connection', true)
+			->will($this->returnValue(true));
+
+		$client = $this->getMockBuilder('\OCP\Http\Client\IClient')
+			->disableOriginalConstructor()->getMock();
+		$client->expects($this->at(0))
+			->method('get')
+			->with('https://www.owncloud.org/', []);
+		$client->expects($this->at(1))
+			->method('get')
+			->with('http://www.owncloud.org/', [])
+			->will($this->throwException(new \Exception()));
+
+		$this->clientService->expects($this->once())
+			->method('newClient')
+			->will($this->returnValue($client));
+
+		$this->assertFalse(
+			\Test_Helper::invokePrivate(
+				$this->checkSetupController,
+				'isInternetConnectionWorking'
+			)
+		);
+	}
+
+	public function testIsMemcacheConfiguredFalse() {
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('memcache.local', null)
+			->will($this->returnValue(null));
+
+		$this->assertFalse(
+			\Test_Helper::invokePrivate(
+				$this->checkSetupController,
+				'isMemcacheConfigured'
+			)
+		);
+	}
+
+	public function testIsMemcacheConfiguredTrue() {
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('memcache.local', null)
+			->will($this->returnValue('SomeProvider'));
+
+		$this->assertTrue(
+			\Test_Helper::invokePrivate(
+				$this->checkSetupController,
+				'isMemcacheConfigured'
+			)
+		);
+	}
+
+	public function testCheck() {
+		$this->config->expects($this->at(0))
+			->method('getSystemValue')
+			->with('has_internet_connection', true)
+			->will($this->returnValue(true));
+		$this->config->expects($this->at(1))
+			->method('getSystemValue')
+			->with('memcache.local', null)
+			->will($this->returnValue('SomeProvider'));
+
+		$client = $this->getMockBuilder('\OCP\Http\Client\IClient')
+			->disableOriginalConstructor()->getMock();
+		$client->expects($this->at(0))
+			->method('get')
+			->with('https://www.owncloud.org/', []);
+		$client->expects($this->at(1))
+			->method('get')
+			->with('http://www.owncloud.org/', [])
+			->will($this->throwException(new \Exception()));
+
+		$this->clientService->expects($this->once())
+			->method('newClient')
+			->will($this->returnValue($client));
+
+		$this->util->expects($this->once())
+			->method('isHtaccessWorking')
+			->will($this->returnValue(true));
+
+		$expected = new DataResponse(
+			[
+				'serverHasInternetConnection' => false,
+				'dataDirectoryProtected' => true,
+				'isMemcacheConfigured' => true,
+			]
+		);
+		$this->assertEquals($expected, $this->checkSetupController->check());
+	}
+}