diff options
| author | Carl Schwan <carl@carlschwan.eu> | 2022-01-26 20:58:39 +0100 |
|---|---|---|
| committer | Carl Schwan <carl@carlschwan.eu> | 2022-05-12 21:02:52 +0200 |
| commit | eef973e85ba5e5cc322079ff85a599d42f1334e6 (patch) | |
| tree | 23d99edd8f57e07973ae1327a67bab3c47f6b1c1 /tests | |
| parent | eb45a6ca404524bad6416ba3b3a755f9faa5e9b8 (diff) | |
| download | nextcloud-server-eef973e85ba5e5cc322079ff85a599d42f1334e6.tar.gz nextcloud-server-eef973e85ba5e5cc322079ff85a599d42f1334e6.zip | |
Minor optimizations for saving user personal information
* Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition
* Make createCard not check if an card exists if we already checked
previously. We also don't try to get the card if the user is disabled
as we don't use the card in this case
We this change we go from 100 DB requests to 80 DB requests when saving
an user email address.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c6fd482edf33214a9ad4787e4cac278f871fa7c8)
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/lib/Accounts/AccountManagerTest.php | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/tests/lib/Accounts/AccountManagerTest.php b/tests/lib/Accounts/AccountManagerTest.php index 9d54ef36c80..69deaf17d3c 100644 --- a/tests/lib/Accounts/AccountManagerTest.php +++ b/tests/lib/Accounts/AccountManagerTest.php @@ -424,7 +424,7 @@ class AccountManagerTest extends TestCase { ], ]; foreach ($users as $userInfo) { - $this->invokePrivate($this->accountManager, 'updateUser', [$userInfo['user'], $userInfo['data'], false]); + $this->invokePrivate($this->accountManager, 'updateUser', [$userInfo['user'], $userInfo['data'], null, false]); } } @@ -466,9 +466,6 @@ class AccountManagerTest extends TestCase { /** @var IUser $user */ $user = $this->createMock(IUser::class); - // FIXME: should be an integration test instead of this abomination - $accountManager->expects($this->once())->method('getUser')->with($user)->willReturn($oldData); - if ($updateExisting) { $accountManager->expects($this->once())->method('updateExistingUser') ->with($user, $newData); @@ -497,10 +494,10 @@ class AccountManagerTest extends TestCase { ); } - $this->invokePrivate($accountManager, 'updateUser', [$user, $newData]); + $this->invokePrivate($accountManager, 'updateUser', [$user, $newData, $oldData]); } - public function dataTrueFalse() { + public function dataTrueFalse(): array { return [ #$newData | $oldData | $insertNew | $updateExisting [['myProperty' => ['value' => 'newData']], ['myProperty' => ['value' => 'oldData']], false, true], |