diff options
Diffstat (limited to 'apps/dav/tests')
-rw-r--r-- | apps/dav/tests/travis/caldavtest/config/serverinfo.xml | 2 | ||||
-rw-r--r-- | apps/dav/tests/unit/connector/sabre/auth.php | 4 | ||||
-rw-r--r-- | apps/dav/tests/unit/connector/sabre/principal.php | 104 |
3 files changed, 48 insertions, 62 deletions
diff --git a/apps/dav/tests/travis/caldavtest/config/serverinfo.xml b/apps/dav/tests/travis/caldavtest/config/serverinfo.xml index 24d63d4a3ae..a474bb7135c 100644 --- a/apps/dav/tests/travis/caldavtest/config/serverinfo.xml +++ b/apps/dav/tests/travis/caldavtest/config/serverinfo.xml @@ -180,7 +180,7 @@ <!-- relative path to main principal collection--> <substitution> <key>$principalcollection:</key> - <value>$root:principals/</value> + <value>$root:principals/users/</value> </substitution> <!-- the core recored type collections--> diff --git a/apps/dav/tests/unit/connector/sabre/auth.php b/apps/dav/tests/unit/connector/sabre/auth.php index 595bd441617..47dd237b761 100644 --- a/apps/dav/tests/unit/connector/sabre/auth.php +++ b/apps/dav/tests/unit/connector/sabre/auth.php @@ -279,7 +279,7 @@ class Auth extends TestCase { ->method('close'); $response = $this->auth->check($request, $response); - $this->assertEquals([true, 'principals/MyWrongDavUser'], $response); + $this->assertEquals([true, 'principals/users/MyWrongDavUser'], $response); } public function testAuthenticateNoBasicAuthenticateHeadersProvided() { @@ -353,7 +353,7 @@ class Auth extends TestCase { ->method('getUser') ->will($this->returnValue($user)); $response = $this->auth->check($server->httpRequest, $server->httpResponse); - $this->assertEquals([true, 'principals/username'], $response); + $this->assertEquals([true, 'principals/users/username'], $response); } public function testAuthenticateInvalidCredentials() { diff --git a/apps/dav/tests/unit/connector/sabre/principal.php b/apps/dav/tests/unit/connector/sabre/principal.php index 2fbab124fb7..9a6ae545b58 100644 --- a/apps/dav/tests/unit/connector/sabre/principal.php +++ b/apps/dav/tests/unit/connector/sabre/principal.php @@ -41,43 +41,45 @@ class Principal extends \Test\TestCase { $fooUser = $this->getMockBuilder('\OC\User\User') ->disableOriginalConstructor()->getMock(); $fooUser - ->expects($this->exactly(3)) - ->method('getUID') - ->will($this->returnValue('foo')); + ->expects($this->exactly(1)) + ->method('getUID') + ->will($this->returnValue('foo')); + $fooUser + ->expects($this->exactly(1)) + ->method('getDisplayName') + ->will($this->returnValue('Dr. Foo-Bar')); + $fooUser + ->expects($this->exactly(1)) + ->method('getEMailAddress') + ->will($this->returnValue('')); $barUser = $this->getMockBuilder('\OC\User\User') ->disableOriginalConstructor()->getMock(); $barUser - ->expects($this->exactly(3)) + ->expects($this->exactly(1)) ->method('getUID') ->will($this->returnValue('bar')); + $barUser + ->expects($this->exactly(1)) + ->method('getEMailAddress') + ->will($this->returnValue('bar@owncloud.org')); $this->userManager ->expects($this->once()) ->method('search') ->with('') ->will($this->returnValue([$fooUser, $barUser])); - $this->config - ->expects($this->at(0)) - ->method('getUserValue') - ->with('foo', 'settings', 'email') - ->will($this->returnValue('')); - $this->config - ->expects($this->at(1)) - ->method('getUserValue') - ->with('bar', 'settings', 'email') - ->will($this->returnValue('bar@owncloud.org')); $expectedResponse = [ 0 => [ - 'uri' => 'principals/foo', - '{DAV:}displayname' => 'foo' + 'uri' => 'principals/users/foo', + '{DAV:}displayname' => 'Dr. Foo-Bar' ], 1 => [ - 'uri' => 'principals/bar', + 'uri' => 'principals/users/bar', '{DAV:}displayname' => 'bar', '{http://sabredav.org/ns}email-address' => 'bar@owncloud.org' ] ]; - $response = $this->connector->getPrincipalsByPrefix('principals'); + $response = $this->connector->getPrincipalsByPrefix('principals/users'); $this->assertSame($expectedResponse, $response); } @@ -88,7 +90,7 @@ class Principal extends \Test\TestCase { ->with('') ->will($this->returnValue([])); - $response = $this->connector->getPrincipalsByPrefix('principals'); + $response = $this->connector->getPrincipalsByPrefix('principals/users'); $this->assertSame([], $response); } @@ -96,7 +98,7 @@ class Principal extends \Test\TestCase { $fooUser = $this->getMockBuilder('\OC\User\User') ->disableOriginalConstructor()->getMock(); $fooUser - ->expects($this->exactly(3)) + ->expects($this->exactly(1)) ->method('getUID') ->will($this->returnValue('foo')); $this->userManager @@ -104,17 +106,12 @@ class Principal extends \Test\TestCase { ->method('get') ->with('foo') ->will($this->returnValue($fooUser)); - $this->config - ->expects($this->once()) - ->method('getUserValue') - ->with('foo', 'settings', 'email') - ->will($this->returnValue('')); $expectedResponse = [ - 'uri' => 'principals/foo', + 'uri' => 'principals/users/foo', '{DAV:}displayname' => 'foo' ]; - $response = $this->connector->getPrincipalByPath('principals/foo'); + $response = $this->connector->getPrincipalByPath('principals/users/foo'); $this->assertSame($expectedResponse, $response); } @@ -122,26 +119,25 @@ class Principal extends \Test\TestCase { $fooUser = $this->getMockBuilder('\OC\User\User') ->disableOriginalConstructor()->getMock(); $fooUser - ->expects($this->exactly(3)) - ->method('getUID') - ->will($this->returnValue('foo')); + ->expects($this->exactly(1)) + ->method('getEMailAddress') + ->will($this->returnValue('foo@owncloud.org')); + $fooUser + ->expects($this->exactly(1)) + ->method('getUID') + ->will($this->returnValue('foo')); $this->userManager ->expects($this->once()) ->method('get') ->with('foo') ->will($this->returnValue($fooUser)); - $this->config - ->expects($this->once()) - ->method('getUserValue') - ->with('foo', 'settings', 'email') - ->will($this->returnValue('foo@owncloud.org')); $expectedResponse = [ - 'uri' => 'principals/foo', + 'uri' => 'principals/users/foo', '{DAV:}displayname' => 'foo', '{http://sabredav.org/ns}email-address' => 'foo@owncloud.org' ]; - $response = $this->connector->getPrincipalByPath('principals/foo'); + $response = $this->connector->getPrincipalByPath('principals/users/foo'); $this->assertSame($expectedResponse, $response); } @@ -152,7 +148,7 @@ class Principal extends \Test\TestCase { ->with('foo') ->will($this->returnValue(null)); - $response = $this->connector->getPrincipalByPath('principals/foo'); + $response = $this->connector->getPrincipalByPath('principals/users/foo'); $this->assertSame(null, $response); } @@ -160,7 +156,7 @@ class Principal extends \Test\TestCase { $fooUser = $this->getMockBuilder('\OC\User\User') ->disableOriginalConstructor()->getMock(); $fooUser - ->expects($this->exactly(3)) + ->expects($this->exactly(1)) ->method('getUID') ->will($this->returnValue('foo')); $this->userManager @@ -168,14 +164,9 @@ class Principal extends \Test\TestCase { ->method('get') ->with('foo') ->will($this->returnValue($fooUser)); - $this->config - ->expects($this->once()) - ->method('getUserValue') - ->with('foo', 'settings', 'email') - ->will($this->returnValue('foo@owncloud.org')); - $response = $this->connector->getGroupMemberSet('principals/foo'); - $this->assertSame(['principals/foo'], $response); + $response = $this->connector->getGroupMemberSet('principals/users/foo'); + $this->assertSame(['principals/users/foo'], $response); } /** @@ -189,14 +180,14 @@ class Principal extends \Test\TestCase { ->with('foo') ->will($this->returnValue(null)); - $this->connector->getGroupMemberSet('principals/foo'); + $this->connector->getGroupMemberSet('principals/users/foo'); } public function testGetGroupMembership() { $fooUser = $this->getMockBuilder('\OC\User\User') ->disableOriginalConstructor()->getMock(); $fooUser - ->expects($this->exactly(3)) + ->expects($this->exactly(1)) ->method('getUID') ->will($this->returnValue('foo')); $this->userManager @@ -204,17 +195,12 @@ class Principal extends \Test\TestCase { ->method('get') ->with('foo') ->will($this->returnValue($fooUser)); - $this->config - ->expects($this->once()) - ->method('getUserValue') - ->with('foo', 'settings', 'email') - ->will($this->returnValue('foo@owncloud.org')); $expectedResponse = [ - 'principals/foo/calendar-proxy-read', - 'principals/foo/calendar-proxy-write' + 'principals/users/foo/calendar-proxy-read', + 'principals/users/foo/calendar-proxy-write' ]; - $response = $this->connector->getGroupMembership('principals/foo'); + $response = $this->connector->getGroupMembership('principals/users/foo'); $this->assertSame($expectedResponse, $response); } @@ -229,7 +215,7 @@ class Principal extends \Test\TestCase { ->with('foo') ->will($this->returnValue(null)); - $this->connector->getGroupMembership('principals/foo'); + $this->connector->getGroupMembership('principals/users/foo'); } /** @@ -237,7 +223,7 @@ class Principal extends \Test\TestCase { * @expectedExceptionMessage Setting members of the group is not supported yet */ public function testSetGroupMembership() { - $this->connector->setGroupMemberSet('principals/foo', ['foo']); + $this->connector->setGroupMemberSet('principals/users/foo', ['foo']); } public function testUpdatePrincipal() { @@ -245,6 +231,6 @@ class Principal extends \Test\TestCase { } public function testSearchPrincipals() { - $this->assertSame([], $this->connector->searchPrincipals('principals', [])); + $this->assertSame([], $this->connector->searchPrincipals('principals/users', [])); } } |