1 files changed, 36 insertions, 42 deletions
diff --git a/apps/files/src/store/userconfig.ts b/apps/files/src/store/userconfig.ts
index ffe07a91bab..95829c849e8 100644
--- a/apps/files/src/store/userconfig.ts
+++ b/apps/files/src/store/userconfig.ts
@@ -2,15 +2,16 @@
  * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import type { UserConfig, UserConfigStore } from '../types'
-import { defineStore } from 'pinia'
+import type { UserConfig } from '../types'
+import { getCurrentUser } from '@nextcloud/auth'
 import { emit, subscribe } from '@nextcloud/event-bus'
-import { generateUrl } from '@nextcloud/router'
 import { loadState } from '@nextcloud/initial-state'
+import { generateUrl } from '@nextcloud/router'
+import { defineStore } from 'pinia'
+import { ref, set } from 'vue'
 import axios from '@nextcloud/axios'
-import Vue from 'vue'
 
-const userConfig = loadState<UserConfig>('files', 'config', {
+const initialUserConfig = loadState<UserConfig>('files', 'config', {
 	show_hidden: false,
 	crop_image_previews: true,
 	sort_favorites_first: true,
@@ -18,45 +19,38 @@ const userConfig = loadState<UserConfig>('files', 'config', {
 	grid_view: false,
 })
 
-export const useUserConfigStore = function(...args) {
-	const store = defineStore('userconfig', {
-		state: () => ({
-			userConfig,
-		} as UserConfigStore),
+export const useUserConfigStore = defineStore('userconfig', () => {
+	const userConfig = ref<UserConfig>({ ...initialUserConfig })
 
-		actions: {
-			/**
-			 * Update the user config local store
-			 * @param key
-			 * @param value
-			 */
-			onUpdate(key: string, value: boolean) {
-				Vue.set(this.userConfig, key, value)
-			},
+	/**
+	 * Update the user config local store
+	 * @param key The config key
+	 * @param value The new value
+	 */
+	function onUpdate(key: string, value: boolean): void {
+		set(userConfig.value, key, value)
+	}
 
-			/**
-			 * Update the user config local store AND on server side
-			 * @param key
-			 * @param value
-			 */
-			async update(key: string, value: boolean) {
-				await axios.put(generateUrl('/apps/files/api/v1/config/' + key), {
-					value,
-				})
-				emit('files:config:updated', { key, value })
-			},
-		},
-	})
+	/**
+	 * Update the user config local store AND on server side
+	 * @param key The config key
+	 * @param value The new value
+	 */
+	async function update(key: string, value: boolean): Promise<void> {
+		// only update if a user is logged in (not the case for public shares)
+		if (getCurrentUser() !== null) {
+			await axios.put(generateUrl('/apps/files/api/v1/config/{key}', { key }), {
+				value,
+			})
+		}
+		emit('files:config:updated', { key, value })
+	}
 
-	const userConfigStore = store(...args)
+	// Register the event listener
+	subscribe('files:config:updated', ({ key, value }) => onUpdate(key, value))
 
-	// Make sure we only register the listeners once
-	if (!userConfigStore._initialized) {
-		subscribe('files:config:updated', function({ key, value }: { key: string, value: boolean }) {
-			userConfigStore.onUpdate(key, value)
-		})
-		userConfigStore._initialized = true
+	return {
+		userConfig,
+		update,
 	}
-
-	return userConfigStore
-}
+})