summaryrefslogtreecommitdiffstats
path: root/apps/files_reminders/lib
diff options
context:
space:
mode:
Diffstat (limited to 'apps/files_reminders/lib')
-rw-r--r--apps/files_reminders/lib/Controller/ApiController.php3
-rw-r--r--apps/files_reminders/lib/Service/ReminderService.php8
2 files changed, 11 insertions, 0 deletions
diff --git a/apps/files_reminders/lib/Controller/ApiController.php b/apps/files_reminders/lib/Controller/ApiController.php
index ddc34b16c6b..30465f6a69b 100644
--- a/apps/files_reminders/lib/Controller/ApiController.php
+++ b/apps/files_reminders/lib/Controller/ApiController.php
@@ -30,6 +30,7 @@ use DateTime;
use DateTimeInterface;
use DateTimeZone;
use Exception;
+use OCA\FilesReminders\Exception\NodeNotFoundException;
use OCA\FilesReminders\Service\ReminderService;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Http;
@@ -95,6 +96,8 @@ class ApiController extends OCSController {
try {
$this->reminderService->createOrUpdate($user, $fileId, $dueDate);
return new JSONResponse([], Http::STATUS_OK);
+ } catch (NodeNotFoundException $e) {
+ return new JSONResponse([], Http::STATUS_NOT_FOUND);
} catch (Throwable $th) {
$this->logger->error($th->getMessage(), ['exception' => $th]);
return new JSONResponse([], Http::STATUS_INTERNAL_SERVER_ERROR);
diff --git a/apps/files_reminders/lib/Service/ReminderService.php b/apps/files_reminders/lib/Service/ReminderService.php
index bf4cd5da14d..fe746dc75ca 100644
--- a/apps/files_reminders/lib/Service/ReminderService.php
+++ b/apps/files_reminders/lib/Service/ReminderService.php
@@ -31,6 +31,7 @@ use DateTimeZone;
use OCA\FilesReminders\AppInfo\Application;
use OCA\FilesReminders\Db\Reminder;
use OCA\FilesReminders\Db\ReminderMapper;
+use OCA\FilesReminders\Exception\NodeNotFoundException;
use OCA\FilesReminders\Exception\UserNotFoundException;
use OCA\FilesReminders\Model\RichReminder;
use OCP\AppFramework\Db\DoesNotExistException;
@@ -78,6 +79,9 @@ class ReminderService {
);
}
+ /**
+ * @throws NodeNotFoundException
+ */
public function createOrUpdate(IUser $user, int $fileId, DateTime $dueDate): void {
$now = new DateTime('now', new DateTimeZone('UTC'));
try {
@@ -86,6 +90,10 @@ class ReminderService {
$reminder->setUpdatedAt($now);
$this->reminderMapper->update($reminder);
} catch (DoesNotExistException $e) {
+ $nodes = $this->root->getUserFolder($user->getUID())->getById($fileId);
+ if (empty($nodes)) {
+ throw new NodeNotFoundException();
+ }
// Create new reminder if no reminder is found
$reminder = new Reminder();
$reminder->setUserId($user->getUID());