1 files changed, 15 insertions, 11 deletions

diff --git a/apps/files_sharing/lib/Controller/ShareController.php b/apps/files_sharing/lib/Controller/ShareController.php
index e2b607f8eb2..5b2a2af4992 100644
--- a/apps/files_sharing/lib/Controller/ShareController.php
+++ b/apps/files_sharing/lib/Controller/ShareController.php
@@ -17,13 +17,17 @@ use OCP\AppFramework\AuthPublicShareController;
 use OCP\AppFramework\Http\Attribute\NoCSRFRequired;
 use OCP\AppFramework\Http\Attribute\OpenAPI;
 use OCP\AppFramework\Http\Attribute\PublicPage;
+use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\AppFramework\Http\RedirectResponse;
 use OCP\AppFramework\Http\TemplateResponse;
+use OCP\Constants;
 use OCP\Defaults;
 use OCP\EventDispatcher\IEventDispatcher;
+use OCP\Files\File;
 use OCP\Files\Folder;
 use OCP\Files\IRootFolder;
+use OCP\Files\Node;
 use OCP\Files\NotFoundException;
 use OCP\IConfig;
 use OCP\IL10N;
@@ -46,7 +50,7 @@ use OCP\Share\IShare;
  */
 #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)]
 class ShareController extends AuthPublicShareController {
-	protected ?Share\IShare $share = null;
+	protected ?IShare $share = null;
 
 	public const SHARE_ACCESS = 'access';
 	public const SHARE_AUTH = 'auth';
@@ -217,7 +221,7 @@ class ShareController extends AuthPublicShareController {
 		$itemType = $itemSource = $uidOwner = '';
 		$token = $share;
 		$exception = null;
-		if ($share instanceof \OCP\Share\IShare) {
+		if ($share instanceof IShare) {
 			try {
 				$token = $share->getToken();
 				$uidOwner = $share->getSharedBy();
@@ -261,7 +265,7 @@ class ShareController extends AuthPublicShareController {
 	 * @param Share\IShare $share
 	 * @return bool
 	 */
-	private function validateShare(\OCP\Share\IShare $share) {
+	private function validateShare(IShare $share) {
 		// If the owner is disabled no access to the link is granted
 		$owner = $this->userManager->get($share->getShareOwner());
 		if ($owner === null || !$owner->isEnabled()) {
@@ -314,7 +318,7 @@ class ShareController extends AuthPublicShareController {
 
 		// We can't get the path of a file share
 		try {
-			if ($shareNode instanceof \OCP\Files\File && $path !== '') {
+			if ($shareNode instanceof File && $path !== '') {
 				$this->emitAccessShareHook($share, 404, 'Share not found');
 				$this->emitShareAccessEvent($share, self::SHARE_ACCESS, 404, 'Share not found');
 				throw new NotFoundException($this->l10n->t('This share does not exist or is no longer available'));
@@ -349,8 +353,8 @@ class ShareController extends AuthPublicShareController {
 
 		$share = $this->shareManager->getShareByToken($token);
 
-		if (!($share->getPermissions() & \OCP\Constants::PERMISSION_READ)) {
-			return new \OCP\AppFramework\Http\DataResponse('Share has no read permission');
+		if (!($share->getPermissions() & Constants::PERMISSION_READ)) {
+			return new DataResponse('Share has no read permission');
 		}
 
 		if (!$this->validateShare($share)) {
@@ -358,7 +362,7 @@ class ShareController extends AuthPublicShareController {
 		}
 
 		// Single file share
-		if ($share->getNode() instanceof \OCP\Files\File) {
+		if ($share->getNode() instanceof File) {
 			// Single file download
 			$this->singleFileDownloaded($share, $share->getNode());
 		}
@@ -378,7 +382,7 @@ class ShareController extends AuthPublicShareController {
 				}
 			}
 
-			if ($node instanceof \OCP\Files\Folder) {
+			if ($node instanceof Folder) {
 				if ($files === null || $files === '') {
 					// The folder is downloaded
 					$this->singleFileDownloaded($share, $share->getNode());
@@ -415,7 +419,7 @@ class ShareController extends AuthPublicShareController {
 	 * @param Share\IShare $share
 	 * @throws NotFoundException when trying to download a folder of a "hide download" share
 	 */
-	protected function singleFileDownloaded(Share\IShare $share, \OCP\Files\Node $node) {
+	protected function singleFileDownloaded(IShare $share, Node $node) {
 		if ($share->getHideDownload() && $node instanceof Folder) {
 			throw new NotFoundException('Downloading a folder');
 		}
@@ -435,14 +439,14 @@ class ShareController extends AuthPublicShareController {
 		$parameters = [$userPath];
 
 		if ($share->getShareType() === IShare::TYPE_EMAIL) {
-			if ($node instanceof \OCP\Files\File) {
+			if ($node instanceof File) {
 				$subject = Downloads::SUBJECT_SHARED_FILE_BY_EMAIL_DOWNLOADED;
 			} else {
 				$subject = Downloads::SUBJECT_SHARED_FOLDER_BY_EMAIL_DOWNLOADED;
 			}
 			$parameters[] = $share->getSharedWith();
 		} else {
-			if ($node instanceof \OCP\Files\File) {
+			if ($node instanceof File) {
 				$subject = Downloads::SUBJECT_PUBLIC_SHARED_FILE_DOWNLOADED;
 				$parameters[] = $remoteAddressHash;
 			} else {